Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3D12_FEATURE_DATA_D3D12_OPTIONS8 should be D3D12_FEATURE_DATA_D3D12_OPTIONS9 #157

Open
SujalBista001 opened this issue Jan 7, 2024 · 0 comments

Comments

@SujalBista001
Copy link

SujalBista001 commented Jan 7, 2024

D3D12_FEATURE_DATA_D3D12_OPTIONS8 should be D3D12_FEATURE_DATA_D3D12_OPTIONS9
Please see - https://learn.microsoft.com/en-us/windows/win32/api/d3d12/ns-d3d12-d3d12_feature_data_d3d12_options9

Change these

Since some drivers have Mesh Shader support without support in pipeline statistics, it is important to use CheckFeatureSupport to query D3D12_FEATURE_DATA_D3D12_OPTIONS8 for MeshShaderPipelineStatsSupported before using Pipeline Statistics to evaluate mesh shader or amplification shader data.

D3D12_FEATURE_DATA_D3D12_OPTIONS8 featureData = {};
pDevice->CheckFeatureSupport(D3D12_FEATURE_D3D12_OPTIONS8, &featureData, sizeof(featureData));
VERIFY_IS_TRUE(featureData.MeshShaderPipelineStatsSupported);

To

Since some drivers have Mesh Shader support without support in pipeline statistics, it is important to use CheckFeatureSupport to query D3D12_FEATURE_DATA_D3D12_OPTIONS9 for MeshShaderPipelineStatsSupported before using Pipeline Statistics to evaluate mesh shader or amplification shader data.

D3D12_FEATURE_DATA_D3D12_OPTIONS9 featureData = {};
pDevice->CheckFeatureSupport(D3D12_FEATURE_D3D12_OPTIONS9, &featureData, sizeof(featureData));
VERIFY_IS_TRUE(featureData.MeshShaderPipelineStatsSupported);

https://github.com/microsoft/DirectX-Specs/blame/dc27f60655480b74a466959739895c64c5dd3a1d/d3d/MeshShader.md#L413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant