Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing view operations from sequence parallel(async). #6750

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

inkcherry
Copy link
Contributor

@inkcherry inkcherry commented Nov 14, 2024

FYI @loadams
add missing view operation.
The shape required for the view cannot be easily obtained in the current function, so refactor layout params code.

@inkcherry
Copy link
Contributor Author

@loadams The CI encountered a "no space left" issue, which doesn't seem to be caused by this patch. Could you please retrigger it? thanks!

@loadams
Copy link
Contributor

loadams commented Dec 5, 2024

@loadams The CI encountered a "no space left" issue, which doesn't seem to be caused by this patch. Could you please retrigger it? thanks!

Hi @inkcherry - yes, sorry that does seem to be an intermittent failure, I'll re-trigger them, but it looks like there are merged conflicts now, could you take a look?

@inkcherry
Copy link
Contributor Author

@loadams Thank you for the reminder, I have resolved and verified the merge conflicts(both ds+megads) : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants