Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump porter + terraform version, template base image Debian versions, and template terraform and az cli versions #4158

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Bump porter + terraform version, template base image Debian versions, and template terraform and az cli versions #4158

wants to merge 13 commits into from
+85 −82

Conversation

jonnyry
Copy link
Collaborator

@jonnyry jonnyry commented Nov 28, 2024 •
edited
Loading

Resolves #4153

What is being addressed

Bumps versions of the following:

In the Dev Container:

  • Porter from v1.0.5 => v.1.2.0
  • Porter Az Plugin from v1.2.0 => v1.2.3
  • Porter Terraform Mixin v1.0.2 => v1.0.5 see below regarding canary release
  • Porter Az Mixin v1.0.1 => v1.0.4 see below regarding canary release
  • Terraform from v1.4.5 => v1.9.8

In template images:

  • Base Debian Image from buster/bullseye => bookworm
  • Terraform from various => 1.9.8
  • Az cli from various => 2.67.0

Note - Porter Mixins canary releases

The Porter project has not yet updated their atom release feed with version numbers for:

  • Porter Terraform Mixin v1.0.5
  • Porter Az Mixin v1.0.4

Consequently even though the builds exist, they are tagged as canary. Hence our code refers to them as canary:

0afa3c6#diff-13bd9d7a30bf46656bc81f1ad5b908a627f9247be3f7d76df862b0578b534fc6R53

The release feed is due to be updated imminently and which point I will update the PR with the correct version numbers

Note 2 - Templates not updated

The following templates were not updated due to incompatibilities that arose while building:

  • OHDSI
  • MLFlow

@github-actions github-actions bot added the external PR from an external contributor label Nov 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit ede6f01.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member

marrobi commented Nov 28, 2024

/test-extended

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

⚠️ When using /test-extended on external PRs, the SHA of the checked commit must be specified

(in response to this comment from @marrobi)

@marrobi
Copy link
Member

marrobi commented Nov 28, 2024

/test-extended 2b48951

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12072967975 (with refid ada819c9)

(in response to this comment from @marrobi)

@jonnyry jonnyry changed the title Bumper Porter, template base image Debian versions, and template terraform and az cli versions Bump Porter version, template base image Debian versions, and template terraform and az cli versions Nov 28, 2024
tim-allen-ck
tim-allen-ck approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@tim-allen-ck tim-allen-ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnyry
Copy link
Collaborator Author

jonnyry commented Nov 29, 2024

@tim-allen-ck @marrobi got a couple of PRs with Porter on the az-mixin and terraform-mixin which remove the remaining critical, high and medium CVEs:

If they get merged soonish then will update this update this PR, if that's OK with you?

@tamirkamara
Copy link
Collaborator

@jonnyry will you also upgrade terraform in devcontainer / core?
(maybe in a different PR)

@jonnyry
Copy link
Collaborator Author

jonnyry commented Nov 29, 2024 •
edited
Loading

@jonnyry will you also upgrade terraform in devcontainer / core? (maybe in a different PR)

Hi @tamirkamara I've just updated the core version in the Dev Container here:

27968e7

Is there somewhere else in the core I'm missing?

@jonnyry jonnyry changed the title Bump Porter version, template base image Debian versions, and template terraform and az cli versions Bump Porter + TF version, template base image Debian versions, and template terraform and az cli versions Nov 29, 2024
@jonnyry jonnyry changed the title Bump Porter + TF version, template base image Debian versions, and template terraform and az cli versions Bump porter + terraform version, template base image Debian versions, and template terraform and az cli versions Nov 29, 2024
@jonnyry jonnyry force-pushed the jr/upstream-main/74-bump-porter-versions branch from f7cda3a to 2b48951 Compare December 1, 2024 13:51
@jonnyry jonnyry marked this pull request as draft December 1, 2024 13:53
@jonnyry
Copy link
Collaborator Author

jonnyry commented Dec 1, 2024

Setting to draft while the following PRs get merged & we can update the mixin version numbers in this PR:

getporter/az-mixin#72
getporter/terraform-mixin#120

@tamirkamara
Copy link
Collaborator

Overall this looks good to me but I think we're waiting to see if we'll be able to use a production channel for the mixins, right?
So I will review once we know we want to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-allen-ck tim-allen-ck tim-allen-ck approved these changes

@tamirkamara tamirkamara Awaiting requested review from tamirkamara

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
external PR from an external contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template images are showing CVEs
4 participants
@jonnyry @marrobi @tamirkamara @tim-allen-ck