Add CMK support for Base Workspace #4161
Open
+211
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…02-cmk-support
…02-cmk-support
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 75fce3a. ♻️ This comment has been updated with latest results. |
yuvalyaron
commented
Dec 1, 2024
tamirkamara
reviewed
Dec 2, 2024
templates/workspaces/base/terraform/airlock/storage_accounts.tf
Outdated
Show resolved
Hide resolved
LizaShak
reviewed
Dec 4, 2024
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12161171332 (with refid (in response to this comment from @yuvalyaron) |
1 similar comment
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12161171332 (with refid (in response to this comment from @yuvalyaron) |
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12181387380 (with refid (in response to this comment from @yuvalyaron) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Resolves #4145
What is being addressed
Added CMK support for the base workspace
How is this addressed
Propagated the
ENABLE_CMK_ENCRYPTIONandKEY_STORE_IDenvironment variables to the resource processor, ensuring the workspace is automatically deployed with CMK encryption if set at the TRE level.Added an identity for the workspace, allowing it to access the Key Vault for creating the CMK.