Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMK support for Base Workspace #4161

Open
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

yuvalyaron
Copy link
Collaborator

@yuvalyaron yuvalyaron commented Dec 1, 2024

Partially Resolves #4145

What is being addressed

Added CMK support for the base workspace

How is this addressed

  • Propagated the ENABLE_CMK_ENCRYPTION and KEY_STORE_ID environment variables to the resource processor, ensuring the workspace is automatically deployed with CMK encryption if set at the TRE level.

  • Added an identity for the workspace, allowing it to access the Key Vault for creating the CMK.

Copy link

github-actions bot commented Dec 1, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 75fce3a.

♻️ This comment has been updated with latest results.

@yuvalyaron yuvalyaron marked this pull request as ready for review December 1, 2024 18:06
@yuvalyaron yuvalyaron changed the title 4145 cmk for base ws Add CMK support for Base Workspace Dec 1, 2024
@yuvalyaron yuvalyaron marked this pull request as draft December 2, 2024 10:55
@yuvalyaron yuvalyaron marked this pull request as ready for review December 2, 2024 15:09
Copy link
Collaborator

@LizaShak LizaShak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuvalyaron
Copy link
Collaborator Author

/test-extended

Copy link

github-actions bot commented Dec 4, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12161171332 (with refid f4f49383)

(in response to this comment from @yuvalyaron)

1 similar comment
Copy link

github-actions bot commented Dec 4, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12161171332 (with refid f4f49383)

(in response to this comment from @yuvalyaron)

@yuvalyaron
Copy link
Collaborator Author

/test-extended

Copy link

github-actions bot commented Dec 5, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12181387380 (with refid f4f49383)

(in response to this comment from @yuvalyaron)

Copy link
Collaborator

@tim-allen-ck tim-allen-ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMK support for resources outside of core
4 participants