Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMK support for Base Workspace #4161

Merged
merged 56 commits into from
Dec 9, 2024

Conversation

yuvalyaron
Copy link
Collaborator

@yuvalyaron yuvalyaron commented Dec 1, 2024

Partially Resolves #4145

What is being addressed

Added CMK support for the base workspace

How is this addressed

  • Propagated the ENABLE_CMK_ENCRYPTION and KEY_STORE_ID environment variables to the resource processor, ensuring the workspace is automatically deployed with CMK encryption if set at the TRE level.

  • Added an identity for the workspace, allowing it to access the Key Vault for creating the CMK.

Copy link
Collaborator

@LizaShak LizaShak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuvalyaron
Copy link
Collaborator Author

/test-extended

Copy link

github-actions bot commented Dec 4, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12161171332 (with refid f4f49383)

(in response to this comment from @yuvalyaron)

1 similar comment
Copy link

github-actions bot commented Dec 4, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12161171332 (with refid f4f49383)

(in response to this comment from @yuvalyaron)

@yuvalyaron
Copy link
Collaborator Author

/test-extended

Copy link

github-actions bot commented Dec 5, 2024

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12181387380 (with refid f4f49383)

(in response to this comment from @yuvalyaron)

Copy link
Collaborator

@tim-allen-ck tim-allen-ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuvalyaron
Copy link
Collaborator Author

/test

Copy link

github-actions bot commented Dec 9, 2024

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12237063379 (with refid f4f49383)

(in response to this comment from @yuvalyaron)

@yuvalyaron
Copy link
Collaborator Author

/test

Copy link

github-actions bot commented Dec 9, 2024

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12237514119 (with refid f4f49383)

(in response to this comment from @yuvalyaron)

@yuvalyaron
Copy link
Collaborator Author

@yuvalyaron
Copy link
Collaborator Author

/test-force-approve

@yuvalyaron yuvalyaron enabled auto-merge (squash) December 9, 2024 23:00
Copy link

github-actions bot commented Dec 9, 2024

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 373f154)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron merged commit ac5787c into microsoft:main Dec 9, 2024
12 checks passed
@yuvalyaron yuvalyaron deleted the 4145-cmk-for-base-ws branch December 9, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMK support for resources outside of core
4 participants