Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update porter version and on error getting porter outputs return dict #3745

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Update porter version and on error getting porter outputs return dict #3745

merged 4 commits into from
Oct 17, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Oct 16, 2023

Resolves #3744

  • Update porter to v1.0.15 as has updated mongo drivers
  • If cannot get outputs return dict so message can be parsed as DeploymentStatusUpdateMessage

@marrobi marrobi enabled auto-merge (squash) October 16, 2023 14:27
@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit b8093b7.

♻️ This comment has been updated with latest results.

martinpeck
martinpeck approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@martinpeck martinpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(subject to testing) LGTM!

@marrobi
Copy link
Member Author

marrobi commented Oct 17, 2023

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/6547707838 (with refid 863b2560)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 984c76e into microsoft:main Oct 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpeck martinpeck martinpeck approved these changes

@tamirkamara tamirkamara Awaiting requested review from tamirkamara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Porter command fails with incomplete read of message header: context deadline exceeded
2 participants
@marrobi @martinpeck