Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to nuget functionality #856

Merged
merged 77 commits into from
Sep 24, 2024
Merged

Changes to nuget functionality #856

merged 77 commits into from
Sep 24, 2024

Conversation

freddydk
Copy link
Contributor

@freddydk freddydk commented Dec 16, 2023

With this release the implementation for delivering to NuGet packages (by adding the NuGetContext secret), is similar to the functionality behind delivering to GitHub packages and the implementation is final.

New Settings:

  • trustMicrosoftNuGetFeeds Unless this setting is set to false, AL-Go for GitHub will trust the NuGet feeds provided by Microsoft. The feeds provided by Microsoft contains all Microsoft apps, all Microsoft symbols and symbols for all AppSource apps.
  • trustedNuGetFeeds - can be an array of NuGet feed specifications, which AL-Go for GitHub will use for dependency resolution. Every feed specification must include a url property and can optionally include a few other properties:
    • Url - The URL of the feed (examples: https://pkgs.dev.azure.com/myorg/apps/\_packaging/myrepo/nuget/v3/index.json or https://nuget.pkg.github.com/mygithuborg/index.json")
    • Patterns - AL-Go for Github will only trust packages, where the ID matches this pattern. Default is all packages (*).
    • FingerPrints - If specified, AL-Go for GitHub will only trust packages signed with one of the fingerprints specified in this array of fingerprints.
    • AuthTokenSecret - If the NuGet feed specified by URL is private, the authTokenSecret must be the name of a secret containing the authentication token with permissions to search and read packages from the NuGet feed

@freddydk freddydk marked this pull request as ready for review September 22, 2024 21:41
@freddydk freddydk requested a review from a team as a code owner September 22, 2024 21:41
Copy link
Collaborator

@mazhelez mazhelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Left some comments, so one more iteration might be needed.

Actions/Deliver/Deliver.ps1 Show resolved Hide resolved
RELEASENOTES.md Outdated Show resolved Hide resolved
RELEASENOTES.md Outdated Show resolved Hide resolved
RELEASENOTES.md Outdated Show resolved Hide resolved
Scenarios/secrets.md Outdated Show resolved Hide resolved
Actions/RunPipeline/RunPipeline.ps1 Show resolved Hide resolved
@freddydk freddydk requested a review from mazhelez September 23, 2024 09:29
@freddydk freddydk merged commit 8d7e66f into microsoft:main Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants