-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCPT Test Report #619
BCPT Test Report #619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me.
Should there be any part of the E2E tests that check any of the new functionality?
Co-authored-by: Maria Zhelezova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't fully agree with adding the bcptThresholds.json file but the rest of the PR looks good and will be a really nice improvement to AL-Go 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expect for the MD generation, the PR looks okay.
Tests are also hard to understand. Maybe using a template for the markdown will help there as well.
Co-authored-by: Maria Zhelezova <[email protected]>
This PR will add a BCPT Test Report to the build summary, looking like this:
You can also add a bcptBaseLine.json to the project in order to establish a baseline for the performance tests.
It looks like this:
TODOs:
Example of bcpt tests with failures and warnings: