From 75523758e183a5e80ab01adfa16f5a12b46773da Mon Sep 17 00:00:00 2001 From: Freddy Kristiansen Date: Tue, 17 Oct 2023 04:06:25 -0700 Subject: [PATCH 1/3] Update README.md (#779) --- README.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 342d4f833..5239f748b 100644 --- a/README.md +++ b/README.md @@ -9,10 +9,11 @@ The template repositories to use as starting point are: - [https://github.com/microsoft/AL-Go-PTE](https://github.com/microsoft/AL-Go-PTE) or [https://aka.ms/algopte](https://aka.ms/algopte) is the GitHub repository template for Per Tenant Extensions. When creating a Per Tenant Extensions, this is your starting point. - [https://github.com/microsoft/AL-Go-AppSource](https://github.com/microsoft/AL-Go-AppSource) or [https://aka.ms/algoappsource](https://aka.ms/algoappsource) is the GitHub repository template for AppSource apps. When creating an AppSource App, this is your starting point. +## AL-Go Workshop -The below usage scenarios takes you through how to get started and how to perform the most common tasks. +Try out the [AL-Go workshop](https://aka.ms/algoworkshop) for an in-depth workshop on AL-Go for GitHub functionality or examine the below usage scenarios, which explains how to get started and how to perform the most common tasks. -## Usage scenarios: +## Usage scenarios 1. [Create a new per-tenant extension (like AL Go) and start developing in VS Code](Scenarios/GetStarted.md) 2. [Add a test app to an existing project](Scenarios/AddATestApp.md) 3. [Register a customer sandbox environment for Continuous Deployment using S2S](Scenarios/RegisterSandboxEnvironment.md) From 7b77018959e05b87c751e9b129837c4c2b53600d Mon Sep 17 00:00:00 2001 From: Freddy Kristiansen Date: Fri, 20 Oct 2023 10:43:54 -0700 Subject: [PATCH 2/3] fix getartfacts (#787) Fix for https://github.com/microsoft/AL-Go/issues/785 Co-authored-by: freddydk --- Actions/Github-Helper.psm1 | 1 + 1 file changed, 1 insertion(+) diff --git a/Actions/Github-Helper.psm1 b/Actions/Github-Helper.psm1 index ad5418b81..a17a5c5b7 100644 --- a/Actions/Github-Helper.psm1 +++ b/Actions/Github-Helper.psm1 @@ -788,6 +788,7 @@ function GetArtifacts { if (-not $result) { Write-Host "- No matching artifacts found" } + $result } function DownloadArtifact { From 3841adc8e37863bba7ebf414d64b1dc2ca5d2ff0 Mon Sep 17 00:00:00 2001 From: Freddy Kristiansen Date: Tue, 7 Nov 2023 09:40:18 +0100 Subject: [PATCH 3/3] issue 799 (#800) Hotfix for issue #799 --------- Co-authored-by: freddydk --- Actions/Github-Helper.psm1 | 6 +++++- .../AppSource App/.github/workflows/PullRequestHandler.yaml | 1 + .../.github/workflows/PullRequestHandler.yaml | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Actions/Github-Helper.psm1 b/Actions/Github-Helper.psm1 index a17a5c5b7..a09e3ce7c 100644 --- a/Actions/Github-Helper.psm1 +++ b/Actions/Github-Helper.psm1 @@ -729,6 +729,10 @@ function GetArtifacts { # Use buildOutput artifact to determine the workflow run id to avoid excessive API calls # Reason: A project called xx-main will match the artifact pattern *-main-*-version, and there might not be any artifacts matching the mask $buildOutputPattern = "*-$branch-BuildOutput-$version" + # Old builds from PR runs are vresioned differently and should be ignored + $ignoreBuildOutputPattern1 = "*-$branch-BuildOutput-*.*.2147483647.0" + # Build Output from TestCurrent, TestNextMinor and TestNextMajor are named differently and should be ignored + $ignoreBuildOutputPattern2 = "*-$branch-BuildOutput-*-*" Write-Host "Analyzing artifacts matching $artifactPattern" while ($true) { if ($total_count -eq 0) { @@ -754,7 +758,7 @@ function GetArtifacts { continue } $matchingArtifacts += @($artifacts.artifacts | Where-Object { !$_.expired -and $_.name -like $artifactPattern }) - $buildOutputArtifacts += @($artifacts.artifacts | Where-Object { !$_.expired -and $_.name -like $buildOutputPattern }) + $buildOutputArtifacts += @($artifacts.artifacts | Where-Object { !$_.expired -and $_.name -like $buildOutputPattern -and $_.name -notlike $ignoreBuildOutputPattern1 -and $_.name -notlike $ignoreBuildOutputPattern2 }) if ($buildOutputArtifacts.Count -gt 0) { # We have matching artifacts. # If the last artifact in the list of artifacts read is not from the same workflow run, there are no more matching artifacts diff --git a/Templates/AppSource App/.github/workflows/PullRequestHandler.yaml b/Templates/AppSource App/.github/workflows/PullRequestHandler.yaml index 6358130e1..7eaee5503 100644 --- a/Templates/AppSource App/.github/workflows/PullRequestHandler.yaml +++ b/Templates/AppSource App/.github/workflows/PullRequestHandler.yaml @@ -94,6 +94,7 @@ jobs: projectDependenciesJson: ${{ needs.Initialization.outputs.projectDependenciesJson }} secrets: 'licenseFileUrl,keyVaultCertificateUrl,*keyVaultCertificatePassword,keyVaultClientId,gitHubPackagesContext,applicationInsightsConnectionString' publishThisBuildArtifacts: ${{ needs.Initialization.outputs.workflowDepth > 1 }} + artifactsNameSuffix: 'PR${{ github.event.number }}' StatusCheck: runs-on: [ windows-latest ] diff --git a/Templates/Per Tenant Extension/.github/workflows/PullRequestHandler.yaml b/Templates/Per Tenant Extension/.github/workflows/PullRequestHandler.yaml index 6358130e1..7eaee5503 100644 --- a/Templates/Per Tenant Extension/.github/workflows/PullRequestHandler.yaml +++ b/Templates/Per Tenant Extension/.github/workflows/PullRequestHandler.yaml @@ -94,6 +94,7 @@ jobs: projectDependenciesJson: ${{ needs.Initialization.outputs.projectDependenciesJson }} secrets: 'licenseFileUrl,keyVaultCertificateUrl,*keyVaultCertificatePassword,keyVaultClientId,gitHubPackagesContext,applicationInsightsConnectionString' publishThisBuildArtifacts: ${{ needs.Initialization.outputs.workflowDepth > 1 }} + artifactsNameSuffix: 'PR${{ github.event.number }}' StatusCheck: runs-on: [ windows-latest ]