Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Renderer shouldn't require a separate components file #856

Open
mikehearn opened this issue Aug 14, 2024 · 0 comments
Open

React Renderer shouldn't require a separate components file #856

mikehearn opened this issue Aug 14, 2024 · 0 comments

Comments

@mikehearn
Copy link
Contributor

Feature description

Currently the React Renderer expects you to compile one or more bundles of components, and also lets you optionally supply a custom render script. The idea is that render scripts are generic, whereas the bundles are app specific.

It turns out that some users find it easier to just create a render script that does everything rather than use the split mechanism. In that case you have to create a fake bundle, which is a bit silly. It'd be better if we made the ssr-components.mjs file optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant