Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ResponseLifecycle from core http-server #837

Draft
wants to merge 1 commit into
base: 4.13.x
Choose a base branch
from
Draft

Use ResponseLifecycle from core http-server #837

wants to merge 1 commit into from

Commits on Nov 20, 2024

  1. Use ResponseLifecycle from core http-server 

    Instead of servlet-specific body encoding logic, use the ResponseLifecycle introduced in core by micronaut-projects/micronaut-core#11342 (pending review). Then we only have to take care of writing the ByteBody to the servlet response.

Some other related changes:

- Improved async reading/writing support, deprecate StreamedServletMessage
- Rework HttpResponse lifecycle management: Core mostly expects HttpResponseFactory to return new, independent responses, but servlet returned views of the same ServletHttpResponse each time (with shared headers and such). New approach is to have only the latest HttpResponse backed by the real ServletHttpResponse, any previous responses are copied snapshots
- Deprecate and stop using ServletResponseEncoder, it is replaced by core ResponseBodyEncoder.

These changes fix all the remaining TCK failures that relate to response handling, except for FilterProxyTest.
    @yawkat
    yawkat committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9bc5e0c View commit details
    Browse the repository at this point in the history