Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation section 6.5.13 is missing source code snippet #2896

Closed
mikehearn opened this issue Apr 19, 2024 · 3 comments · May be fixed by #2932
Closed

Documentation section 6.5.13 is missing source code snippet #2896

mikehearn opened this issue Apr 19, 2024 · 3 comments · May be fixed by #2932
Labels
lang: kotlin Issues or features specific to Kotlin type: docs

Comments

@mikehearn
Copy link

Expected Behavior

Section 6.5.13 says "The following record class demonstrates this capability" and should be followed by a source snippet.

Actual Behaviour

No source code is visible, although the annotations are.

Steps To Reproduce

https://micronaut-projects.github.io/micronaut-data/latest/guide/#javaRecords

Environment Information

No response

Example Application

https://micronaut-projects.github.io/micronaut-data/latest/guide/#javaRecords

Version

Current
@radovanradic
Copy link
Contributor

I can see it
Screenshot 2024-04-19 at 11 27 10 AM

@mikehearn
Copy link
Author

I see. If you select Kotlin for a code snippet earlier up the page, then it disappears, presumably because there's no Kotlin equivalent for this section but the js code assumes there always will be.

@sdelamo sdelamo added the lang: kotlin Issues or features specific to Kotlin label Apr 19, 2024
wetted added a commit that referenced this issue May 3, 2024
@wetted
Refactor documentation for Java Records and Kotlin Data Classes to en…
74d38db 
…sure asciidoc snippets have examples for all languages, and to eliminate embedded code in asciidoc (that is not compiled and untested).

closes #2896
@wetted wetted mentioned this issue May 3, 2024
Draft
@wetted wetted moved this to Ready for Review in 4.5.0 Release May 3, 2024
@timyates timyates mentioned this issue May 10, 2024
Merged
@radovanradic
Copy link
Contributor

It appears to be fixed by micronaut-projects/micronaut-build#684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang: kotlin Issues or features specific to Kotlin type: docs
Projects
No open projects
4.5.0 Release
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor documentation for Java Records and Kotlin Data Classes micronaut-projects/micronaut-data
4 participants
@sdelamo @mikehearn @wetted @radovanradic