Skip to content

Latest commit

 

History

History
98 lines (57 loc) · 4.27 KB

CONTRIBUTING.md

File metadata and controls

98 lines (57 loc) · 4.27 KB
Raw

Contributing Code or Documentation to Micronaut

Sign the Contributor License Agreement (CLA). This is required before any of your code or pull-requests are accepted.

Finding Issues to Work on

If you are interested in contributing to Micronaut and are looking for issues to work on, take a look at the issues tagged with help wanted.

JDK Setup

Micronaut control-panel currently requires JDK 8.

IDE Setup

Micronaut control-panel can be imported into IntelliJ IDEA by opening the build.gradle file.

Docker Setup

Micronaut control-panel tests currently require Docker to be installed.

Running Tests

To run the tests, use ./gradlew check.

Building Documentation

The documentation sources are located at src/main/docs/guide.

To build the documentation, run ./gradlew publishGuide (or ./gradlew pG), then open build/docs/index.html

To also build the Javadocs, run ./gradlew docs.

Working on the code base

If you use IntelliJ IDEA, you can import the project using the Intellij Gradle Tooling ("File / Import Project" and selecting the "settings.gradle" file).

To get a local development version of Micronaut XXX working, first run the publishToMavenLocal task.

./gradlew pTML

You can then reference the version specified with projectVersion in gradle.properties in a test project's build.gradle or pom.xml. If you use Gradle, add the mavenLocal repository (Maven automatically does this):

repositories {
    mavenLocal()
    mavenCentral()
}

Creating a pull request

Once you are satisfied with your changes:

  • Commit your changes in your local branch
  • Push your changes to your remote branch on GitHub
  • Send us a pull request

Merging a pull request

Before we merge into a module's master branch a PR, we have to consider.

Can this PR be merged into a patch release (e.g. documentation fixes, bug fix, patch transitive dependency upgrade, breaking change due to security, Github actions sync, Micronaut Build Plugin upgrade)?

Should this PR be merged into the next minor version of the module? For example, a new feature, a new module, or a minor transitive dependency upgrade.

If the PR is going into the next minor version of the module, we need to release a patch version, and branch off master a new branch for the current minor module's version. If the gradle.properties's projectVersion is 3.1.2-SNAPSHOT the branch should be named 3.1.x, and we push it to Github. If master contains only commits such as Github actions sync (no commits with benefits to users), we can branch off without doing a patch release.

When you merge a PR which will go into the next Module's minor.

  • Update gradle.properties's githubCoreBranch to point to the next minor branch of Micronaut Core.
  • Update gradle.properties's projectVersion to the next minor snapshot.
  • Upgrade the module to the latest version of Micronaut.

Checkstyle

We want to keep the code clean, following good practices about organization, Javadoc, and style as much as possible.

Micronaut XXX uses Checkstyle to make sure that the code follows those standards. The configuration is defined in config/checkstyle/checkstyle.xml. To execute Checkstyle, run:

./gradlew <module-name>:checkstyleMain

Before starting to contribute new code we recommended that you install the IntelliJ CheckStyle-IDEA plugin and configure it to use Micronaut's checkstyle configuration file.

IntelliJ will mark in red the issues Checkstyle finds. For example:

In this case, to fix the issues, we need to:

  • Add one empty line before package in line 16
  • Add the Javadoc for the constructor in line 27
  • Add an space after if in line 34

The plugin also adds a new tab in the bottom of the IDE to run Checkstyle and show errors and warnings. We recommend that you run the report and fix all issues before submitting a pull request.