Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format Admin Settings #999

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Format Admin Settings #999

wants to merge 2 commits into from

Conversation

SteveMicroNova
Copy link
Contributor

@SteveMicroNova SteveMicroNova commented Nov 19, 2024 •
edited
Loading

What does this change intend to accomplish?

Indents subsections to make it more obvious that they are part of a given subheader, align buttons and textboxes, get rid of hoverover tooltips and add them to the top of settings subsections

Closes #998

Before:
image

After:
image

Checklist

  • Have you tested your changes and ensured they work?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass linting & tests? You can test on localhost using ./scripts/test
  • If this is a UI change, have you tested it across multiple browser platforms on both desktop and mobile?

rtertiaer
rtertiaer requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@rtertiaer rtertiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you're at it, can you align the textbox elements so they don't look haphazard?

@rtertiaer
Copy link
Contributor

imo, tooltips like this are not good design. they are less accessible than the alternative of just describing the feature below its heading, and still aren't actually obvious, even with your svg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klay2000 klay2000 Awaiting requested review from klay2000

@LegendaryMichael LegendaryMichael Awaiting requested review from LegendaryMichael

@rtertiaer rtertiaer Awaiting requested review from rtertiaer

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format Admin Settings tooltip
2 participants
@SteveMicroNova @rtertiaer