-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input component #59
Comments
This ticket covers the improvements of the input fields color palette. In staging we have some inconsistencies with the value and placeholder text colors. The modifications should be applied to all different fields that are presented in a form. Inputs that have color issues:
DescriptionThe inputs:
Have a different text value color than the mockup in Figma. And the input Phone number in Personal information has a different color for the placeholder.Pre-requirements:
Steps to reproduce
Actual resultsThe inputs in the professional profile have a text value color of #575f65 The input in the personal profile have a placeholder color of #6b7280 Expected result:The inputs must have a text value color of #15162F And the placeholder should have the same color as in the mockup Component/viewProfessional Profile > Work information Professional Profile > My projects at michelada Personal Profile > Personal information EnvironmentStaging |
Description
Based on the Ctrl project needs, we detect some inconsistencies in the INPUT component.
Our goal with this ticket is to fix how this component looks, remove the unnecessary code from Ctrl.
And be able to consume the component from the DS without adding extra css or js to make it work in Ctrl.
Narrative
Design System: https://www.figma.com/file/c1SBfQGUU3twlW3YjeL8Sx/michelada_DS?node-id=0%3A1
Control project: https://www.figma.com/file/TmTjBO1Ua93cm6B978ErDw/ControlMocks_21-0ct-2020?node-id=3456%3A0
Video explanation
https://michelada.slack.com/archives/C0279KDU485/p1643667745441619?thread_ts=1643666990.610879&cid=C0279KDU485
Related issues from Gitlab Ctrl project
https://git.michelada.io/products/ctrl/-/issues/274
Definition of done
Acceptance criteria
The text was updated successfully, but these errors were encountered: