We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current library implementation: https://github.com/michaeldzjap/rand-seed/blob/develop/src/Algorithms/Xoshiro128ss.ts#L40 Current version 1.1 written in C: https://xoshiro.di.unimi.it/xoshiro128starstar.c
There are 2 major differences:
s[0]
this.a
s[1]
this.b
Note that version 1.0 had mistakenly s[0] instead of s[1] as state word passed to the scrambler.
r
// current r = (r << 7) | ((r >>> 25) * 9); // proper r = ((r << 7) | (r >>> 25)) * 9;
With changes applied new implementation will of course generate different numbers for the same seeds, which means it's not backwards compatible.
The text was updated successfully, but these errors were encountered:
Thanks for reporting @rinart73 . Will pick this up as soon as I have time.
Sorry, something went wrong.
michaeldzjap
Successfully merging a pull request may close this issue.
Current library implementation: https://github.com/michaeldzjap/rand-seed/blob/develop/src/Algorithms/Xoshiro128ss.ts#L40
Current version 1.1 written in C: https://xoshiro.di.unimi.it/xoshiro128starstar.c
There are 2 major differences:
s[0]
(this.a
), rather thans[1]
(this.b
). This is explicitly marked as a mistake that they fixed:r
has incorrect order of operations:With changes applied new implementation will of course generate different numbers for the same seeds, which means it's not backwards compatible.
The text was updated successfully, but these errors were encountered: