-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this library still actively maintained? #36
Comments
It's so sad, that this powerful library is not up-to-date with the current SvelteKit Version, what can we do about that? |
I was hoping to have the current owner migrate to me otherwise I'll have to make another separate repo. I wanted to submit PRs but evidently the owner doesn't watch this repo and so I doubt there would be any merging even if I create a good PR with updates... |
Yeah I think he doesn't look over this repo anymore.. unfortunately. Would you do another repo? And is it fine with the rights to do that? I would be a big fan of this library to be still maintained. You have my support! :) |
Maybe it would be possible to send him a email or something.. i want this library so bad. |
That was one of the main reasons I reached out, but not super sure what to do with no response. Now most can be achieved with transitions and view transitions API now but still I used this framer motion library and like the declarative nature. And would like to make components that wrap with popmotion and svelte transitions and view transitions API |
That's a good idea, I'll try to email later and see if I get a response 👍 |
Yes, I really fell in love with the declarative way of animations. I think svelte-motion is the only one who achieved it so powerful! Would really appreciate it, if u can keep me updated.. you have my support by the way. I would be down to support you with my contributions. |
I'd like to follow updates here as well! :) |
So far I've reached out by email and have not gotten a response back yet. |
I think he does reply on PRs, at least he replied to mine updating all the dependencies. So, I would suggest that if you have some good updates, then just try and drop a PR. |
awesome, thank you! I might, the main idea I had was to update to support svelte 5 which the component type needs to change to support svelte 4 and 5. also there is a bug with AnimatePresence with it's type declaration. |
So, my PR is merged. I guess simply try to open one yourself :) |
Update: I will be opening PR soon with some of my ideas hopefully it gets merged 👍 |
Update: sent PR with the minor changes I mentioned (component type and AnimatePresence bug fix) |
The library is great, but I feel like the updates from the original author are quite slow. I get it, life happens - but @JonathonRP seems to be keen on keeping it alive? @JonathonRP - would you consider re-publishing it under another name? rp-motion? :) |
I might, one day but I don't want to take it from the current author. He hasn't experienced interest in letting me fork and take ownership so I'm just making contributions and have a port to typescript PR and plans to bring it more inline with modern features and implementation of framer motion |
Whatever happens I'd love to be able to use this in my projects again. @micha-lmxt Please consider allowing @JonathonRP to fork or transfer to them if you are no longer interested in maintaining - no hard feelings :) |
Anyone interested in porting this project over to svelte5/ kit2? |
I'm doing that, and while porting to typescript btw |
@JonathonRP anywhere we could track progress and/or assist in any way? |
#47 is the pull request, been doing my best with commit messages to track progress. I have some changes not completely tested on branch right now but I'll be checking them in soon. Could use help testing, last test the functionality and animations were not working but I think I finally figured out why, but unable to test with my project that I've been testing with. That's actually the reason for the slowness in progress. Note: I have aspersions to update and add features that are missing in this lib from original as original is still maintained, and also looking at using svelte built in transitions/ animations down the road. |
changes are pushed, the main thing that could help speed process is having others test that functionality didn't change |
How can I help. Also will this pr be merged? @JonathonRP |
@cliffordkleinsr, if you are able to test functionality and contribute to PR changes that would be great help. the current PR is just to port to typescript and not change or break any current functionality. |
I honestly feel like it does not make much sense to wait on current maintainer - he's been busy/quiet for past couple of months (I also see that he became inactive on twitter). It would totally make sense to fork this into a new library. I feel like svelte-motion is a bit confusing name to begin with (I know it comes from Framer motion), as svelte itself has a svelte/motion module. |
I may fork if he doesn't merge but I wanted to have a resource for learning and self taught to learn about animation which is made easier by using typescript. @ermincelikovic |
I don't know, some examples
|
@ermincelikovic
|
motion-start is great imho! remotion is a product (google it) - would be easily mistaken |
Yeah I was actually back and forth between remotion and (re-motion - little play on my name Reese) but there's also something really nice about motion-start |
svelte-framer |
@ermincelikovic @cliffordkleinsr
|
+1 for |
Please no svelteMotion, it will add even more to the confusion of svelte-motion, svelte/motion 😅 At the end of the day, it does not matter as long as we get to use it :) |
Checking on npm packaging looks like I can't have svelte/framer-motion, because npm only allows @org/package name so it would have to be @svelte/framer-motion which I don't think svelte maintainers would appreciate... So it would have to be motion-start (framer-motion is the package) and (svelte-framer-motion seems a little too verbose) I could be swayed to svelte-motion-start |
Welp, I guess that'll have to do. Can we register it? @JonathonRP |
I will try to figureout how |
Will also check tomorrow . Out of the office IRL |
@cliffordkleinsr, |
I vote for motion-start |
This |
@cliffordkleinsr, @ermincelikovic btw the typescript port is basically ready aside from testing that no functionality was added or lost. |
will try and do some tests tomorrow. Which org should we register for the package? |
I wasn't going to us an org for the package... Also we should use changesets with this new package - this should have necessary information to add changesets to the code base and typescript port code base. |
Will do then. Let's start with the repo forking into the new |
@cliffordkleinsr, are you forking or do you want me to fork? |
Please fork @JonathonRP . Let's get this show on the road |
@cliffordkleinsr, I already have a fork that was used to create PRs. https://github.com/JonathonRP/svelte-motion. should I change repo name and package.json name to motion-start or make it a template repo and make another with mentioned name? |
@cliffordkleinsr, @ermincelikovic please find new repo - https://github.com/JonathonRP/motion-start please test typescript and note it is 0.0.1 and alpha so expect bugs. |
Good start @JonathonRP. Looks like you already registered the package. |
Hey @JonathonRP Some good news I've created a bunch of UI tests you can run using the motion-start local repo here. You can do an Some bad news is however that all the UI tests apart from the Animatepresence stack have failed. There might be some type errors with the Motion and MotionSSR components. There are also a lot of unused exports on the type definitions for these components |
@cliffordkleinsr, thought I already registered the name motion-start with npm by publishing the package to npm |
No worries, went in to publish in the morning then found out that it's taken. Hadn't read your comment. |
@cliffordkleinsr, Interesting looking at this you're using svelte-motion and not motion-start Maybe start a discord server so we can continue discussing there instead of this GitHub issue? |
I tested with both. It's only worked for animatedpresence with the motion-start library |
Here is the discord btw: |
Good news!Framer Motion is now independent, introducing Motion.
|
If it's not, I would love to take it over.
The text was updated successfully, but these errors were encountered: