Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this library still actively maintained? #36

Open
JonathonRP opened this issue Jun 20, 2023 · 57 comments
Open

Is this library still actively maintained? #36

JonathonRP opened this issue Jun 20, 2023 · 57 comments

Comments

@JonathonRP
Copy link
Contributor

JonathonRP commented Jun 20, 2023

If it's not, I would love to take it over.

@enisbudancamanak
Copy link

It's so sad, that this powerful library is not up-to-date with the current SvelteKit Version, what can we do about that?

@JonathonRP
Copy link
Contributor Author

It's so sad, that this powerful library is not up-to-date with the current SvelteKit Version, what can we do about that?

I was hoping to have the current owner migrate to me otherwise I'll have to make another separate repo. I wanted to submit PRs but evidently the owner doesn't watch this repo and so I doubt there would be any merging even if I create a good PR with updates...

@enisbudancamanak
Copy link

Yeah I think he doesn't look over this repo anymore.. unfortunately. Would you do another repo? And is it fine with the rights to do that? I would be a big fan of this library to be still maintained. You have my support! :)

@enisbudancamanak
Copy link

Maybe it would be possible to send him a email or something.. i want this library so bad.

@JonathonRP
Copy link
Contributor Author

Yeah I think he doesn't look over this repo anymore.. unfortunately. Would you do another repo? And is it fine with the rights to do that? I would be a big fan of this library to be still maintained. You have my support! :)

That was one of the main reasons I reached out, but not super sure what to do with no response. Now most can be achieved with transitions and view transitions API now but still I used this framer motion library and like the declarative nature. And would like to make components that wrap with popmotion and svelte transitions and view transitions API

@JonathonRP
Copy link
Contributor Author

Maybe it would be possible to send him a email or something.. i want this library so bad.

That's a good idea, I'll try to email later and see if I get a response 👍

@enisbudancamanak
Copy link

Yes, I really fell in love with the declarative way of animations. I think svelte-motion is the only one who achieved it so powerful!

Would really appreciate it, if u can keep me updated.. you have my support by the way. I would be down to support you with my contributions.

@fmaiabatista
Copy link

I'd like to follow updates here as well! :)

@JonathonRP
Copy link
Contributor Author

So far I've reached out by email and have not gotten a response back yet.

@jbirtel
Copy link
Contributor

jbirtel commented Dec 8, 2023

It's so sad, that this powerful library is not up-to-date with the current SvelteKit Version, what can we do about that?

I was hoping to have the current owner migrate to me otherwise I'll have to make another separate repo. I wanted to submit PRs but evidently the owner doesn't watch this repo and so I doubt there would be any merging even if I create a good PR with updates...

I think he does reply on PRs, at least he replied to mine updating all the dependencies. So, I would suggest that if you have some good updates, then just try and drop a PR.

@JonathonRP
Copy link
Contributor Author

It's so sad, that this powerful library is not up-to-date with the current SvelteKit Version, what can we do about that?

I was hoping to have the current owner migrate to me otherwise I'll have to make another separate repo. I wanted to submit PRs but evidently the owner doesn't watch this repo and so I doubt there would be any merging even if I create a good PR with updates...

I think he does reply on PRs, at least he replied to mine updating all the dependencies. So, I would suggest that if you have some good updates, then just try and drop a PR.

awesome, thank you! I might, the main idea I had was to update to support svelte 5 which the component type needs to change to support svelte 4 and 5. also there is a bug with AnimatePresence with it's type declaration.

@jbirtel
Copy link
Contributor

jbirtel commented Dec 12, 2023

So, my PR is merged. I guess simply try to open one yourself :)

@JonathonRP
Copy link
Contributor Author

Update: I will be opening PR soon with some of my ideas hopefully it gets merged 👍

@JonathonRP
Copy link
Contributor Author

Update: sent PR with the minor changes I mentioned (component type and AnimatePresence bug fix)

@ermincelikovic
Copy link

ermincelikovic commented May 6, 2024

The library is great, but I feel like the updates from the original author are quite slow. I get it, life happens - but @JonathonRP seems to be keen on keeping it alive?

@JonathonRP - would you consider re-publishing it under another name? rp-motion? :)

@JonathonRP
Copy link
Contributor Author

The library is great, but I feel like the updates from the original author are quite slow. I got it, life happens - but @JonathonRP seems to be keen to keep it alive?

@JonathonRP - would you consider re-publishing it under another name? rp-motion? :)

I might, one day but I don't want to take it from the current author. He hasn't experienced interest in letting me fork and take ownership so I'm just making contributions and have a port to typescript PR and plans to bring it more inline with modern features and implementation of framer motion

@didier
Copy link

didier commented Jun 1, 2024

Whatever happens I'd love to be able to use this in my projects again. @micha-lmxt Please consider allowing @JonathonRP to fork or transfer to them if you are no longer interested in maintaining - no hard feelings :)

@cliffordkleinsr
Copy link

Anyone interested in porting this project over to svelte5/ kit2?

@JonathonRP
Copy link
Contributor Author

Anyone interested in porting this project over to svelte5/ kit2?

I'm doing that, and while porting to typescript btw

@didier
Copy link

didier commented Sep 23, 2024

@JonathonRP anywhere we could track progress and/or assist in any way?

@JonathonRP
Copy link
Contributor Author

JonathonRP commented Sep 23, 2024

@JonathonRP anywhere we could track progress and/or assist in any way?

#47 is the pull request, been doing my best with commit messages to track progress. I have some changes not completely tested on branch right now but I'll be checking them in soon. Could use help testing, last test the functionality and animations were not working but I think I finally figured out why, but unable to test with my project that I've been testing with. That's actually the reason for the slowness in progress.

Note: I have aspersions to update and add features that are missing in this lib from original as original is still maintained, and also looking at using svelte built in transitions/ animations down the road.
This typescript port begins taking steps in that direction.

@JonathonRP
Copy link
Contributor Author

@JonathonRP anywhere we could track progress and/or assist in any way?

#47 is the pull request, been doing my best with commit messages to track progress. I have some changes not completely tested on branch right now but I'll be checking them in soon. Could use help testing, last test the functionality and animations were not working but I think I finally figured out why, but unable to test with my project that I've been testing with. That's actually the reason for the slowness in progress.

Note: I have aspersions to update and add features that are missing in this lib from original as original is still maintained, and also looking at using svelte built in transitions/ animations down the road. This typescript port begins taking steps in that direction.

changes are pushed, the main thing that could help speed process is having others test that functionality didn't change

@cliffordkleinsr
Copy link

How can I help. Also will this pr be merged? @JonathonRP

@JonathonRP
Copy link
Contributor Author

How can I help. Also will this pr be merged? @JonathonRP

@cliffordkleinsr, if you are able to test functionality and contribute to PR changes that would be great help. the current PR is just to port to typescript and not change or break any current functionality.
my current understanding is it will get merged by current maintainer, I asked a question in issues here if he would accept a typescript port PR, he said yes. The PR is currently draft because during my testing functionality was broken but I think I fixed it, just need the latest changes tested to make sure that functionality is truly working and unchanged.

@ermincelikovic
Copy link

I honestly feel like it does not make much sense to wait on current maintainer - he's been busy/quiet for past couple of months (I also see that he became inactive on twitter).

It would totally make sense to fork this into a new library. I feel like svelte-motion is a bit confusing name to begin with (I know it comes from Framer motion), as svelte itself has a svelte/motion module.

@JonathonRP
Copy link
Contributor Author

JonathonRP commented Sep 23, 2024

I honestly feel like it does not make much sense to wait on current maintainer - he's been busy/quiet for past couple of months (I also see that he became inactive on twitter).

It would totally make sense to fork this into a new library. I feel like svelte-motion is a bit confusing name to begin with (I know it comes from Framer motion), as svelte itself has a svelte/motion module.

I may fork if he doesn't merge but I wanted to have a resource for learning and self taught to learn about animation which is made easier by using typescript.

@ermincelikovic
What name do you think would be good for a fork?

@ermincelikovic
Copy link

I don't know, some examples

  • rp-motion (gotta give yourself some credit)
  • declarative-motion (still motion, but not to be confused with svelte/motion)
  • motion-kit or motionkit (available on npm)
  • svelte-moves - a bit funky :)

@JonathonRP
Copy link
Contributor Author

I don't know, some examples

  • rp-motion (gotta give yourself some credit)
  • declarative-motion (still motion, but not to be confused with svelte/motion)
  • motion-kit or motionkit (available on npm)
  • svelte-moves - a bit funky :)

@ermincelikovic
I was thinking

  • remotion
  • svelte/animation or svelte/animations
  • motion-start

@ermincelikovic
Copy link

I don't know, some examples

  • rp-motion (gotta give yourself some credit)
  • declarative-motion (still motion, but not to be confused with svelte/motion)
  • motion-kit or motionkit (available on npm)
  • svelte-moves - a bit funky :)

@ermincelikovic I was thinking

  • remotion
  • svelte/animation or svelte/animations
  • motion-start

motion-start is great imho!

remotion is a product (google it) - would be easily mistaken
svelte/animation could be mistaken for svelte/animate

@JonathonRP
Copy link
Contributor Author

JonathonRP commented Sep 23, 2024

I don't know, some examples

  • rp-motion (gotta give yourself some credit)
  • declarative-motion (still motion, but not to be confused with svelte/motion)
  • motion-kit or motionkit (available on npm)
  • svelte-moves - a bit funky :)

@ermincelikovic I was thinking

  • remotion
  • svelte/animation or svelte/animations
  • motion-start

motion-start is great imho!

remotion is a product (google it) - would be easily mistaken
svelte/animation could be mistaken for svelte/animate

Yeah I was actually back and forth between remotion and (re-motion - little play on my name Reese) but there's also something really nice about motion-start

@cliffordkleinsr
Copy link

svelte-framer
svelte-framerMotion
svelterMotion
@ermincelikovic @JonathonRP

@JonathonRP
Copy link
Contributor Author

JonathonRP commented Sep 23, 2024

svelte-framer
svelte-framerMotion
svelterMotion
@ermincelikovic @JonathonRP

@ermincelikovic @cliffordkleinsr
I like svelteMotion.
I thought of some others too,

  • svelte/motion-start
  • svelte/framer-motion

@cliffordkleinsr
Copy link

cliffordkleinsr commented Sep 23, 2024

+1 for svelte/framer-motion
Honestly have been itching to port the library into svelte5

@ermincelikovic
Copy link

Please no svelteMotion, it will add even more to the confusion of svelte-motion, svelte/motion 😅
svelte-framer-motion is not bad, but it has nothing to do with framer.

At the end of the day, it does not matter as long as we get to use it :)

@JonathonRP
Copy link
Contributor Author

JonathonRP commented Sep 23, 2024

+1 for svelte/framer-motion
Honestly have been itching to port the library into svelte5

Checking on npm packaging looks like I can't have svelte/framer-motion, because npm only allows @org/package name so it would have to be @svelte/framer-motion which I don't think svelte maintainers would appreciate... So it would have to be motion-start (framer-motion is the package) and (svelte-framer-motion seems a little too verbose) I could be swayed to svelte-motion-start

@ermincelikovic @cliffordkleinsr

@cliffordkleinsr
Copy link

Welp, I guess that'll have to do. Can we register it? @JonathonRP

@JonathonRP
Copy link
Contributor Author

Welp, I guess that'll have to do. Can we register it? @JonathonRP

I will try to figureout how

@cliffordkleinsr
Copy link

Will also check tomorrow . Out of the office IRL

@JonathonRP
Copy link
Contributor Author

JonathonRP commented Sep 23, 2024

Will also check tomorrow . Out of the office IRL

@cliffordkleinsr,
Which name are you registering tomorrow,
svelte-motion-start or motion-start

@ermincelikovic
Copy link

I vote for motion-start

@cliffordkleinsr
Copy link

I vote for motion-start

This

@JonathonRP
Copy link
Contributor Author

@cliffordkleinsr, @ermincelikovic btw the typescript port is basically ready aside from testing that no functionality was added or lost.

@cliffordkleinsr
Copy link

cliffordkleinsr commented Sep 23, 2024

will try and do some tests tomorrow. Which org should we register for the package?
Should also have a discord or something.

@JonathonRP
Copy link
Contributor Author

JonathonRP commented Sep 23, 2024

will try and do some tests tomorrow. Which org should we register for the package? Should also have a discord or something.

I wasn't going to us an org for the package...
if you want to setup discord server that is fine.

Also we should use changesets with this new package - this should have necessary information to add changesets to the code base and typescript port code base.

@cliffordkleinsr

@cliffordkleinsr
Copy link

Will do then. Let's start with the repo forking into the new motion-start lib. Will try and register the npm tomorrow and get the discord up. initialize the library with the changesets workflow probably then we can start porting changes.

@JonathonRP
Copy link
Contributor Author

@cliffordkleinsr, are you forking or do you want me to fork?

@cliffordkleinsr
Copy link

@cliffordkleinsr, are you forking or do you want me to fork?

Please fork @JonathonRP . Let's get this show on the road

@JonathonRP
Copy link
Contributor Author

@cliffordkleinsr, I already have a fork that was used to create PRs. https://github.com/JonathonRP/svelte-motion. should I change repo name and package.json name to motion-start or make it a template repo and make another with mentioned name?

@JonathonRP
Copy link
Contributor Author

JonathonRP commented Sep 23, 2024

@cliffordkleinsr, @ermincelikovic please find new repo - https://github.com/JonathonRP/motion-start
typescript port and changesets are in codebase and name svelte-motion is now reserved as it's published on npm fyi

please test typescript and note it is 0.0.1 and alpha so expect bugs.

@cliffordkleinsr
Copy link

cliffordkleinsr commented Sep 24, 2024

Good start @JonathonRP. Looks like you already registered the package.

@cliffordkleinsr
Copy link

cliffordkleinsr commented Sep 24, 2024

Hey @JonathonRP Some good news I've created a bunch of UI tests you can run using the motion-start local repo here. You can do an npm link on the motion start forked repo so you can test UI errors locally on the motion-test repository that I have shared

Some bad news is however that all the UI tests apart from the Animatepresence stack have failed. There might be some type errors with the Motion and MotionSSR components. There are also a lot of unused exports on the type definitions for these components

@JonathonRP
Copy link
Contributor Author

JonathonRP commented Sep 24, 2024

Good start @JonathonRP. Looks like you already registered the package.

@cliffordkleinsr, thought I already registered the name motion-start with npm by publishing the package to npm

@cliffordkleinsr
Copy link

cliffordkleinsr commented Sep 24, 2024

Good start @JonathonRP. Looks like you already registered the package.

I thought I already registered the name motion-start with npm by publishing the package to npm

No worries, went in to publish in the morning then found out that it's taken. Hadn't read your comment.
😅

@JonathonRP
Copy link
Contributor Author

JonathonRP commented Sep 24, 2024

Hey @JonathonRP Some good news I've created a bunch of UI tests you can run using the motion-start local repo here. You can do an npm link on the motion start forked repo so you can test UI errors locally on the motion-test repository that I have shared

Some bad news is however that all the UI tests apart from the Animatepresence stack have failed. There might be some type errors with the Motion and MotionSSR components. There are also a lot of unused exports on the type definitions for these components

@cliffordkleinsr, Interesting looking at this you're using svelte-motion and not motion-start

Maybe start a discord server so we can continue discussing there instead of this GitHub issue?

@cliffordkleinsr
Copy link

I tested with both. It's only worked for animatedpresence with the motion-start library

@cliffordkleinsr
Copy link

cliffordkleinsr commented Sep 24, 2024

Here is the discord btw:
EDIT : fresh link
https://discord.gg/r6tSZjdR
The library can be found here: https://www.npmjs.com/package/motion-start

@agrear
Copy link

agrear commented Nov 17, 2024

Good news!

Framer Motion is now independent, introducing Motion.

For a long time, users have asked to use Framer Motion outside of React. Either with vanilla JS, or other frameworks like Vue.

Today, Motion becomes more than a React library, with an amazing set of vanilla APIs that bring Motion's hybrid engine and extensive feature set to everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants