Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are pull requests welcome? #17

Open
hgy59 opened this issue Jul 20, 2024 · 1 comment
Open

Are pull requests welcome? #17

hgy59 opened this issue Jul 20, 2024 · 1 comment

Comments

@hgy59
Copy link
Contributor

hgy59 commented Jul 20, 2024

Since there is no information provided whether this repository accepts pull requests (no README, or Code of conduct or Contributing available), I use this issue to hopefully get an answer...

I use a modified version of Srtm2Osm that is based on version 1.13.

While having problems with two hgt files, I found this repository here and with version 1.16 Srtm2Osm works well.

My modified version of Srtm2Osm has an (optional) parameter -first <elevation> to define the minimum elevation level to create contours for.
Is use this parameter together with -set like this:

  • for 10m contours: -step 10 -first 10
  • for 20m contours: -step 20 -first 20

The reason is to avoid 0m contours and contours below sea level for regular maps.
For maps with land below sea level this parameter must be omitted.

If there is a chance that my enhancement will be integrated, I can provide a pull request.

@mibe
Copy link
Owner

mibe commented Jul 22, 2024

Yes, PRs are absolutely welcome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants