Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support padded domains for non-linear scales #17

Closed
mhkeller opened this issue Feb 3, 2020 · 2 comments
Closed

Support padded domains for non-linear scales #17

mhkeller opened this issue Feb 3, 2020 · 2 comments
Labels
enhancement New feature or request pr-welcome

Comments

@mhkeller
Copy link
Owner

mhkeller commented Feb 3, 2020

The padding option works for linear scales but wouldn't work great for log or power scales since it's based on a proportion.

The related issue is perhaps this will be included as a basic D3 scale feature: d3/d3-scale#150

That issue also has information on Vega's implementation of this idea, which could serve as a blueprint.
@mhkeller mhkeller added enhancement New feature or request pr-welcome labels Feb 3, 2020
@mhkeller
Copy link
Owner Author

This is being done on the padding branch.

@mhkeller
Copy link
Owner Author

This is now done. @veltman found a way to fix the padding issue. I'll merge into master this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request pr-welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhkeller