Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2 Regression in Single-Value Quantile #7

Open
wspeirs opened this issue Aug 17, 2022 · 1 comment
Open

v0.2 Regression in Single-Value Quantile #7

wspeirs opened this issue Aug 17, 2022 · 1 comment

Comments

@wspeirs
Copy link

wspeirs commented Aug 17, 2022

There appears to be a regression in v0.2 for single-value sketches... quick testing shows the issue with any value, and any quantile:

    let mut dd = DDSketch::new(Config::defaults());

    dd.add(1234f64);

    assert_eq!(1234f64, dd.quantile(0.5).unwrap().unwrap());

The above works (produces 1234.0) in v0.1.3, but produces 1224.3764974385315 in v0.2.0/master.

@mheffner
Copy link
Owner

Thanks for filing @wspeirs. The latest version v0.2.0 is supposed to follow the Python implementation (Go too?) a bit closer, so I may take a look and see what those implementations report for single-value sketches too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants