Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging of JS and GO test branches #2

Open
akvlad opened this issue Jan 27, 2023 · 0 comments
Open

Merging of JS and GO test branches #2

akvlad opened this issue Jan 27, 2023 · 0 comments

Comments

@akvlad
Copy link
Contributor

akvlad commented Jan 27, 2023

Goal

Have JS e2e test branch refactored the same way as the GO branch.

Why

Currently we have main js branch with a messy one-function e2e test
On the other hand there's a cloki-go branch refactored into multiple test cases running in a special order.
We need the main branch to be refactored the same way.

How

There are two ways of doing this

I We can repeat the same refactoring for the main branch

Split one test case into a set of smaller cases and make a mechanism to run them in a strict order

II We can merge cloki-go and main branches

Compare two branches. Compare the test cases for each branch.

The second way is harder but preferred because we get understanding the API difference between versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant