Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute require inside MetaScript context #34

Open
tshemsedinov opened this issue Nov 12, 2020 · 2 comments
Open

Execute require inside MetaScript context #34

tshemsedinov opened this issue Nov 12, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@tshemsedinov
Copy link
Member

Now if we load module inside MetaScript and pass require to it's context so module can load another module, this require will be executed in the global context of all application, not in internal MetaScript context. We need special require implementation to be executed inside MetaScript context.

@tshemsedinov tshemsedinov added the enhancement New feature or request label Nov 12, 2020
tshemsedinov pushed a commit that referenced this issue Apr 11, 2022
tshemsedinov pushed a commit that referenced this issue Apr 11, 2022
tshemsedinov pushed a commit that referenced this issue Apr 11, 2022
@tshemsedinov
Copy link
Member Author

@AliusDieMorietur #58 landed but I'll close this issue after internal module nested require and commonjs cache implemented. Also need more tests for permissions. I hope will do that next week.

@tshemsedinov
Copy link
Member Author

Main feature we need is loading npm packages in sandboxes with support of sandboxing nesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant