-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen dependency on jstransformers #179
Comments
I've become member of the jstransformer's org and have updated the 2 jstransformers mentioned.
Disadvantages:
|
To be aligned with @metalsmith/in-place 5.x |
webketje
added a commit
that referenced
this issue
Feb 14, 2024
Adds required transform option, as aligned with metalsmith/in-place
webketje
added a commit
that referenced
this issue
Feb 14, 2024
…ired transform option to support custom transformers, no longer supports multiple transformers per instantiation This change is breaking because layouts now requires at least the transform option, and multi-transformer instantiations including mixed engineOptions must now be split over multiple instantiations This is aligned with metalsmith/in-place Also refactors tests to use async/await
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some of the JS transformers are severely outdated and due to the update mechanism (
jstransformer-boilerplate
->test-jstransformer
->jstransformer-*
) this is probably going to keep being an issue in the future.For example:
jstransformer-marked
uses[email protected]
while the latest version is4.0.7
(4 years ahead)jstransformer-handlebars
uses[email protected]
while the latest version is4.7.7
(6 years ahead)Furthermore the
renderAsync
method used in layouts is not guaranteed to be present on all jstransformers.There are a few options:
peerDependencies
andpeerDependenciesMeta: optional
transformers: ['path/to/transformer.js', 'path/to/other/transformer.js
]` that will be added to the cache with the node_modules transformers, update the docs explaining how to create your own jstransformer.In favor of option 3
The text was updated successfully, but these errors were encountered: