Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fix Set image tag for release branches and tags #1776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Fix Set image tag for release branches and tags #1776

wants to merge 1 commit into from

Conversation

7h3-3mp7y-m4n
Copy link

✨

What this PR does / why we need it:
This PR solves image tags, by adding a verification check and also setting the tag automatically

**Which issue(s) this PR fixes
Fixes #1722

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2024
@metal3-io-bot
Copy link
Contributor

Hi @7h3-3mp7y-m4n. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 8, 2024
@tuminoid
Copy link
Member

tuminoid commented Jun 10, 2024 •
edited
Loading

/ok-to-test

Thanks for the PR! Please set the PR type to :seedling in the title. I'll review this shortly after all basic tests pass.

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2024
@7h3-3mp7y-m4n 7h3-3mp7y-m4n changed the title Fix Set image tag for release branches and tags 🌱 Fix Set image tag for release branches and tags Jun 14, 2024
@Rozzii Rozzii modified the milestones: BMO - v0.7.0, BMO - v0.6.2 Jun 28, 2024
@7h3-3mp7y-m4n
Copy link
Author

7h3-3mp7y-m4n commented Jul 19, 2024 •
edited
Loading

Sorry for the delay, as I see markdownlint and shellcheck are the recheck ones, I will raise a PR soon with a fix.

@7h3-3mp7y-m4n
Copy link
Author

7h3-3mp7y-m4n commented Jul 29, 2024 •
edited
Loading

/retest

@7h3-3mp7y-m4n
Copy link
Author

@tuminoid can you tell me what I am missing here? cause I'm confused

@tuminoid
Copy link
Member

tuminoid commented Oct 3, 2024

Let's run a retest so we can have fresh logs, the old logs have expired already.

/retest

@metal3-io-bot
Copy link
Contributor

@7h3-3mp7y-m4n: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
shellcheck a142955 link true /test shellcheck
markdownlint a142955 link true /test markdownlint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tuminoid
Copy link
Member

tuminoid commented Oct 3, 2024

@tuminoid can you tell me what I am missing here? cause I'm confused

Please check the details links of shellcheck and markdownlint for details what is failing.

For the markdownlink checker failure, I'm not sure what that is complaining about as it just says "action failed" with no logs, I'll look into that.

@7h3-3mp7y-m4n
Copy link
Author

@tuminoid can you tell me what I am missing here? cause I'm confused

Please check the details links of shellcheck and markdownlint for details what is failing.

For the markdownlink checker failure, I'm not sure what that is complaining about as it just says "action failed" with no logs, I'll look into that.

Thanks @tuminoid I'll look into that

@Rozzii Rozzii modified the milestones: BMO - v0.8.0, BMO - v0.9.0 Nov 6, 2024
@Rozzii
Copy link
Member

Rozzii commented Nov 27, 2024

Are you still working on this @7h3-3mp7y-m4n ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rj1k s3rj1k Awaiting requested review from s3rj1k

@tuminoid tuminoid Awaiting requested review from tuminoid

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Metal3 - Roadmap
Status: BMO WIP
Milestone
BMO - v0.9
Development

Successfully merging this pull request may close these issues.

Set image tag for release branches and tags
4 participants
@7h3-3mp7y-m4n @metal3-io-bot @tuminoid @Rozzii