From 1da61b3d691d3bda01a42a6a187ec1cbf2daf2f0 Mon Sep 17 00:00:00 2001 From: twodoorcoupe Date: Fri, 22 Mar 2024 09:07:37 +0100 Subject: [PATCH 1/4] Add mapping for synced lyrics tag --- appendices/tag_mapping.rst | 15 +++++++++++++++ tag_mapping.py | 11 +++++++++++ 2 files changed, 26 insertions(+) diff --git a/appendices/tag_mapping.rst b/appendices/tag_mapping.rst index 20b193270..d2b4f6384 100644 --- a/appendices/tag_mapping.rst +++ b/appendices/tag_mapping.rst @@ -550,6 +550,21 @@ Lyrics :sup:`[4]` "RIFF INFO", "n/a" +Synced Lyrics +-------------- +.. csv-table:: + :width: 100% + :widths: 37 100 + + "Internal Name", "``syncedlyrics:language:description``" + "ID3v2", "``SYLT:description``" + "Vorbis", "n/a" + "APEv2", "n/a" + "iTunes MP4", "n/a" + "ASF/Windows Media", "n/a" + "RIFF INFO", "n/a" + + `Media `_ ------------------------------------------------------ .. csv-table:: diff --git a/tag_mapping.py b/tag_mapping.py index 984623627..99d461022 100644 --- a/tag_mapping.py +++ b/tag_mapping.py @@ -472,6 +472,17 @@ "riff": "n/a", }, + { + "tag_name": "Synced Lyrics", + "picard_name": "``syncedlyrics:language:description``", + "id3v2": "``SYLT:description``", + "vorbis": "n/a", + "apev2": "n/a", + "itunes": "n/a", + "wmp": "n/a", + "riff": "n/a", + }, + { "tag_name": "`Media `_", "picard_name": "``media``", From eb1d5ad2c4749331011d8b44d903104f4865f369 Mon Sep 17 00:00:00 2001 From: twodoorcoupe Date: Sat, 23 Mar 2024 20:16:03 +0100 Subject: [PATCH 2/4] Add synced lyrics to basic tags page --- variables/tags_basic.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/variables/tags_basic.rst b/variables/tags_basic.rst index a9c322682..f03990826 100644 --- a/variables/tags_basic.rst +++ b/variables/tags_basic.rst @@ -242,6 +242,10 @@ These tags are not able to be populated by stock Picard, however they may be use The lyrics for the track. +**syncedlyrics** + + The synced lyrics for the track. + **musicip_fingerprint** The MusicIP Fingerprint for the track. From 4ba88fd06051ce203ccc2d945a152a79bf3841c1 Mon Sep 17 00:00:00 2001 From: twodoorcoupe Date: Sat, 23 Mar 2024 20:20:52 +0100 Subject: [PATCH 3/4] Add name to acknowledgements --- about_picard/acknowledgements.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/about_picard/acknowledgements.rst b/about_picard/acknowledgements.rst index aec974355..446ff3875 100644 --- a/about_picard/acknowledgements.rst +++ b/about_picard/acknowledgements.rst @@ -14,6 +14,7 @@ Contributors include (in alphabetic surname order): - Pavan Chander - Ronan Desplanques - Gabriel Ferreira +- Giorgio Fontanive - Rahul Kumar Gupta - Wieland Hoffmann - InvisibleMan78 From a65c53e75ef8f2a18791668c153e4ba90fc6bef6 Mon Sep 17 00:00:00 2001 From: twodoorcoupe Date: Sat, 23 Mar 2024 20:26:02 +0100 Subject: [PATCH 4/4] Apply suggestion in basic tags page --- variables/tags_basic.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/variables/tags_basic.rst b/variables/tags_basic.rst index f03990826..a9056e5ab 100644 --- a/variables/tags_basic.rst +++ b/variables/tags_basic.rst @@ -244,7 +244,7 @@ These tags are not able to be populated by stock Picard, however they may be use **syncedlyrics** - The synced lyrics for the track. + The synchronized lyrics for the track. **musicip_fingerprint**