Fixes to AzureStorageDriver #448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
The switch for the createStorageDriver call in StorageDriverFactory was missing the case for the backup upload task type. Fixes mesosphere-backup#446
The static initializer for AzureStorageDriver does not work as expected. Changing to be consistent with how the logger is resolved in other files. Fixes mesosphere-backup#447
Uses the CloudBlobContainer abstraction to write the schema to a well-known path. Fixes mesosphere-backup#450
AzureStorageDriver downloads to a different location from the S3StorageDriver. This makes the download behavior more consistent. Fixes mesosphere-backup#449
|
@triclambert could someone take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in StorageDriverFactory that prevents the AzureStorageDriver from being created by the factory, and fixes logging in the AzureStorageDriver. This PR also adds support for schema upload / download for Azure Blob storage, and fixes a bug that caused the restore operation to download files to the wrong location.
Fixes #446
Fixes #447
Fixes #449
Fixes #450