Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify path to a grid file #204

Closed
mogres opened this issue Oct 16, 2023 · 0 comments · Fixed by #205
Closed

Add option to specify path to a grid file #204

mogres opened this issue Oct 16, 2023 · 0 comments · Fixed by #205
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mogres
Copy link
Collaborator

mogres commented Oct 16, 2023

Use Case

cellPACK currently has a boolean option to load_from_grid_file which loads the grid from a predetermined path. It would be good to have an option in the config to specify a path to a file to load the grid from. This could be related to #202.

Solution

Change the load_from_grid_file option to accept path arguments. If the path does not exist or is missing, fall back to the predetermined path. Create and save a new grid file if none of the previous files exist.

This enhancement is particularly useful while packing complex grids.

@mogres mogres added enhancement New feature or request good first issue Good for newcomers labels Oct 16, 2023
@mogres mogres moved this to In Progress in Cellpack Project Planning Oct 18, 2023
@mogres mogres moved this from In Progress to In Review or Blocked in Cellpack Project Planning Oct 18, 2023
@github-project-automation github-project-automation bot moved this from In Review or Blocked to Done in Cellpack Project Planning Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant