diff --git a/config/detekt/detekt-baseline.xml b/config/detekt/detekt-baseline.xml index 927f9a593..c41d1c503 100644 --- a/config/detekt/detekt-baseline.xml +++ b/config/detekt/detekt-baseline.xml @@ -133,7 +133,7 @@ FinalNewline:UsbRepositoryModule.kt$com.geeksville.mesh.repository.usb.UsbRepositoryModule.kt ForbiddenComment:MapFragment.kt$// TODO: Accept filename input param from user ForbiddenComment:SafeBluetooth.kt$SafeBluetooth$// TODO: display some kind of UI about restarting BLE - FunctionNaming:PacketDao.kt$PacketDao$@Query("DELETE FROM packet WHERE uuid=:uuid") fun _delete(uuid: Long) + FunctionNaming:PacketDao.kt$PacketDao$@Query("DELETE FROM packet WHERE uuid=:uuid") suspend fun _delete(uuid: Long) FunctionNaming:QuickChatActionDao.kt$QuickChatActionDao$@Query("Delete from quick_chat where uuid=:uuid") fun _delete(uuid: Long) FunctionParameterNaming:LocationUtils.kt$_degIn: Double FunctionParameterNaming:LocationUtils.kt$lat_a: Double @@ -231,7 +231,6 @@ MagicNumber:EditListPreference.kt$12 MagicNumber:EditListPreference.kt$12345 MagicNumber:EditListPreference.kt$67890 - MagicNumber:EditWaypointDialog.kt$0.4f MagicNumber:EditWaypointDialog.kt$123 MagicNumber:EditWaypointDialog.kt$128169 MagicNumber:EditWaypointDialog.kt$128205 @@ -284,7 +283,6 @@ MagicNumber:MeshService.kt$MeshService$32 MagicNumber:MeshService.kt$MeshService$60000 MagicNumber:MeshService.kt$MeshService$8 - MagicNumber:MessagesFragment.kt$MessagesFragment$200 MagicNumber:MetricsViewModel.kt$MetricsViewModel$1000L MagicNumber:MetricsViewModel.kt$MetricsViewModel$1e-5 MagicNumber:MetricsViewModel.kt$MetricsViewModel$1e-7 @@ -369,7 +367,6 @@ MagicNumber:TCPInterface.kt$TCPInterface$500 MagicNumber:UIState.kt$4 MatchingDeclarationName:AnalyticsClient.kt$AnalyticsProvider - MatchingDeclarationName:CompatExtensions.kt$PendingIntentCompat MatchingDeclarationName:DistanceExtensions.kt$DistanceUnit MatchingDeclarationName:LocationUtils.kt$GPSFormat MatchingDeclarationName:MeshServiceStarter.kt$ServiceStarter : Worker @@ -484,7 +481,6 @@ MultiLineIfElse:Channel.kt$Channel$when (loraConfig.modemPreset) { ModemPreset.SHORT_TURBO -> "ShortTurbo" ModemPreset.SHORT_FAST -> "ShortFast" ModemPreset.SHORT_SLOW -> "ShortSlow" ModemPreset.MEDIUM_FAST -> "MediumFast" ModemPreset.MEDIUM_SLOW -> "MediumSlow" ModemPreset.LONG_FAST -> "LongFast" ModemPreset.LONG_SLOW -> "LongSlow" ModemPreset.LONG_MODERATE -> "LongMod" ModemPreset.VERY_LONG_SLOW -> "VLongSlow" else -> "Invalid" } MultiLineIfElse:ChannelFragment.kt$channelSet = copy { settings.add(it) } MultiLineIfElse:ChannelFragment.kt$channelSet = copy { settings[index] = it } - MultiLineIfElse:ChannelFragment.kt$item { PreferenceFooter( enabled = enabled, onCancelClicked = { focusManager.clearFocus() showChannelEditor = false channelSet = channels }, onSaveClicked = { focusManager.clearFocus() // viewModel.setRequestChannelUrl(channelUrl) sendButton() }) } MultiLineIfElse:ChannelOption.kt$when (bandwidth) { 31 -> .03125f 62 -> .0625f 200 -> .203125f 400 -> .40625f 800 -> .8125f 1600 -> 1.6250f else -> bandwidth / 1000f } MultiLineIfElse:ContextServices.kt$MaterialAlertDialogBuilder(this) .setTitle(title) .setMessage(rationale) .setNeutralButton(R.string.cancel) { _, _ -> } .setPositiveButton(R.string.accept) { _, _ -> invokeFun() } .show() MultiLineIfElse:ContextServices.kt$invokeFun() @@ -610,7 +606,6 @@ NoConsecutiveBlankLines:IRadioInterface.kt$ NoConsecutiveBlankLines:NOAAWmsTileSource.kt$NOAAWmsTileSource$ NoConsecutiveBlankLines:NodeInfo.kt$ - NoConsecutiveBlankLines:PositionTest.kt$ NoConsecutiveBlankLines:PreviewParameterProviders.kt$ NoConsecutiveBlankLines:SafeBluetooth.kt$ NoConsecutiveBlankLines:SafeBluetooth.kt$SafeBluetooth$ @@ -629,7 +624,6 @@ NoWildcardImports:SafeBluetooth.kt$import android.bluetooth.* NoWildcardImports:SafeBluetooth.kt$import kotlinx.coroutines.* NoWildcardImports:SettingsFragment.kt$import com.geeksville.mesh.android.* - NoWildcardImports:UIState.kt$import com.geeksville.mesh.* NoWildcardImports:UsbRepository.kt$import kotlinx.coroutines.flow.* OptionalAbstractKeyword:SyncContinuation.kt$Continuation$abstract ParameterListWrapping:AppPrefs.kt$FloatPref$(thisRef: AppPrefs, prop: KProperty<Float>) @@ -641,7 +635,6 @@ RethrowCaughtException:SyncContinuation.kt$Continuation$throw ex ReturnCount:ChannelOption.kt$internal fun LoRaConfig.radioFreq(channelNum: Int): Float ReturnCount:MainActivity.kt$MainActivity$override fun onOptionsItemSelected(item: MenuItem): Boolean - ReturnCount:MeshService.kt$MeshService$private fun handleReceivedData(packet: MeshPacket) ReturnCount:RadioConfigViewModel.kt$RadioConfigViewModel$private fun processPacketResponse(packet: MeshProtos.MeshPacket) SpacingAroundColon:PreviewParameterProviders.kt$NodeInfoPreviewParameterProvider$: SpacingAroundCurly:AppPrefs.kt$FloatPref$} @@ -652,7 +645,6 @@ SpacingAroundRangeOperator:BatteryInfo.kt$.. StringTemplate:NodeInfo.kt$Position$${time} SwallowedException:BluetoothInterface.kt$BluetoothInterface$ex: CancellationException - SwallowedException:ChannelFragment.kt$ex: Throwable SwallowedException:ChannelSet.kt$ex: Throwable SwallowedException:DeviceVersion.kt$DeviceVersion$e: Exception SwallowedException:Exceptions.kt$ex: Throwable @@ -672,7 +664,6 @@ TooGenericExceptionCaught:BTScanModel.kt$BTScanModel$ex: Throwable TooGenericExceptionCaught:BluetoothInterface.kt$BluetoothInterface$ex: Exception TooGenericExceptionCaught:ChannelFragment.kt$ex: Exception - TooGenericExceptionCaught:ChannelFragment.kt$ex: Throwable TooGenericExceptionCaught:ChannelSet.kt$ex: Throwable TooGenericExceptionCaught:DeviceVersion.kt$DeviceVersion$e: Exception TooGenericExceptionCaught:Exceptions.kt$ex: Throwable @@ -748,7 +739,6 @@ WildcardImport:SafeBluetooth.kt$import android.bluetooth.* WildcardImport:SafeBluetooth.kt$import kotlinx.coroutines.* WildcardImport:SettingsFragment.kt$import com.geeksville.mesh.android.* - WildcardImport:UIState.kt$import com.geeksville.mesh.* WildcardImport:UsbRepository.kt$import kotlinx.coroutines.flow.*