-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Migrate logrus to slog #258
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
bump |
working on the logging part now |
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
@acald-creator Is this issue still open? |
UPDATE:
slog
is currently available in Go1.21
, and we should make the effort to migrate to useslog
.Current Behavior
meshkit
useslogrus
for custom logging, and we created a custom logger that only returns certain fields such aswarn
info
error
debug
But we're lacking on the other fields that
logrus
has and we're using a mixture oflogrus
and our custom logger.meshkit
will benefit from having more fields to call from, when utilizing the custom logging tool inmeshery
. This will help migratemesheryctl
to use the custom logger, instead of callinglogrus
directly.For this purpose of tracking the migration, we will be migrating to use
slog
instead, which is slightly basic but gives us a bit more ability to customize logging and use more fields.Here are the fields that
slog
currently supportsInfo
InfoCtx
Warn
WarnCtx
Debug
DebugCtx
Error
ErrorCtx
There is no built-in support for formatting strings, but
slog
allows us to create our own fields.Desired Behavior
Opening this issue to track the progress.
Resources
Alternatives / Additional Context
The text was updated successfully, but these errors were encountered: