Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a pluggable "bypass MFA if..." solution (for example: "save this browser", or IP based) #47

Open
benzkji opened this issue May 17, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@benzkji
Copy link
Contributor

benzkji commented May 17, 2019

as seen many times.

maybe as a generic solution, that allows to bypass 2FA, given a condition?

@bbisk bbisk added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 20, 2019
@bbisk
Copy link
Contributor

bbisk commented May 20, 2019

In one of current projects we extended trench with IP whitelisting.
So, what's your idea in depth? Mix user agent data and IP? On our TODO list there is also geolocation. Happy to discuss the topic further.

@benzkji
Copy link
Contributor Author

benzkji commented May 21, 2019

Yes, why not mix it all up ;-) As you said you already implemented IP whitelisting, it would be interesting to have a generic solution, and maybe the most common bypass methods built into trench, easily pluggable.

"save this browser" could be one of these. Implementation details up to discuss - some use cookies (with a secret, as value) to remember and verify a browser (kind of a long living 2FA session). If trench is used via tokenauth/jwt from apps, this could be another secret, to be provided, instead of triggering 2FA (I'm not really into Mobile Dev...just thinking loud ;-).

@benzkji benzkji changed the title somehow support "save this browser" feature implement a pluggable "bypass MFA if..." solution (for example: "save this browser", or IP based) May 21, 2019
@ckcollab
Copy link

Would it make sense to store this information/flag in a server-side cookie? That way it's not by IP or anything, just trusting the particular device storing the cookie. I think this makes sense?

@benzkji
Copy link
Contributor Author

benzkji commented Mar 17, 2020

sure. what we would need, is a pluggable system, where devs could add their own whitelisting methods. some builtin would be nice, cookie and ip for example, as basic showcases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants