From fa67deb4d30f1b900e0c5dc2016df51a939abb55 Mon Sep 17 00:00:00 2001 From: Oscar <1570691+oscr@users.noreply.github.com> Date: Sat, 12 Nov 2022 15:54:30 +0100 Subject: [PATCH] Update golangci-lint version (1.41.1 -> 1.50.0). Enable dupword linter (#120) --- .golangci.yml | 1 + hack/check_golangci-lint.sh | 2 +- pkg/metrics/cinder.go | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 3eb75ce..d4afd72 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -7,6 +7,7 @@ linters: - gofmt - goheader - govet + - dupword linters-settings: goheader: template: | diff --git a/hack/check_golangci-lint.sh b/hack/check_golangci-lint.sh index 7f904f7..7d65075 100755 --- a/hack/check_golangci-lint.sh +++ b/hack/check_golangci-lint.sh @@ -3,7 +3,7 @@ set -e -GOLANGCILINT_VERSION="1.41.1" +GOLANGCILINT_VERSION="1.50.0" GOLANGCILINT_FILENAME="golangci-lint-${GOLANGCILINT_VERSION}-linux-amd64.tar.gz" GOLANGCILINT_URL="https://github.com/golangci/golangci-lint/releases/download/v${GOLANGCILINT_VERSION}/${GOLANGCILINT_FILENAME}" diff --git a/pkg/metrics/cinder.go b/pkg/metrics/cinder.go index c2002ad..7971c35 100644 --- a/pkg/metrics/cinder.go +++ b/pkg/metrics/cinder.go @@ -168,7 +168,7 @@ func publishVolumeMetrics(v volumes.Volume, pv *corev1.PersistentVolume) { k8sMetadata := extractK8sMetadata(pv) // add the k8s specific labels. - // We do not need need to check them, because the empty string is totally fine. + // We do not need to check them, because the empty string is totally fine. labels = append(labels, k8sMetadata...) // set the volume-specific metrics