Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix details modal on collections page #592

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Fix details modal on collections page #592

wants to merge 8 commits into from

Conversation

pablodiegoss
Copy link
Member

Description

Updated the data used by the details modal, it still used data from the old /elements/get endpoint, while requesting to the new /api/v1/ endpoint.

Resolves (Issues)

Resolves: #588

General tasks performed

  • Updated the API to have the missing data for the details modal
  • Created a new ProfileSerializer
  • Updated the details modal to use the correct data from the API response

Have you confirmed the application builds locally without error? See here.

  • Yes

rodrigocam
rodrigocam approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@rodrigocam rodrigocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! We can't save this codebase anymore 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigocam rodrigocam rodrigocam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Details modal not working
2 participants
@pablodiegoss @rodrigocam