Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1360 api docs reference resolution #1362

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

t-burch
Copy link
Collaborator

@t-burch t-burch commented Nov 26, 2024

No description provided.

- Create a new test class `OpenAPI31ReferencesTest` for validating OpenAPI 3.1 references.
- Implement setup method to initialize the router and load OpenAPI specs.
- Update test cases to handle requests for both `/pets` and `/users` endpoints.
- Modify the existing OpenAPI specification to include server information in the YAML configuration.
…ptor

- Import Json31 from Swagger library
- Serialize OpenAPI records to JSON bytes in returnOpenApiAsYaml method
- Update XML configuration to reference OpenAPI specification location
t-burch and others added 3 commits November 26, 2024 13:35
- Modify `OpenAPIPublisherInterceptor` to serialize rewritten OpenAPI record to YAML response.
- Update `OpenAPIRecordFactory` to create `OpenAPIRecord` using parsed `OpenAPI` objects.
- Add `getSpec()` method to convert `OpenAPI` to `JsonNode` for schema retrieval.
- Adjust XML configuration to reference OpenAPI specification files correctly.
@t-burch t-burch requested a review from predic8 November 26, 2024 13:22
Copy link
Member

@predic8 predic8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consolidate this with the OpenAPIRecordFactory refactoring. Let's do that next week together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI 3.1: api-docs does not work with split OpenAPI documents (Swagger UI/OpenAPI download)
2 participants