Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Container Support #149

Open
viceice opened this issue Jan 20, 2021 · 4 comments
Open

Windows Container Support #149

viceice opened this issue Jan 20, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@viceice
Copy link

viceice commented Jan 20, 2021

Is your feature request related to a problem? Please describe.
I Like to use this plugin on a windows container runtime.

Describe the solution you'd like
Publish multiarch docker images.

Describe alternatives you've considered
Building multiarch docker images myself as already done here 🙃

Additional context
no

@kakkoyun kakkoyun added good first issue Good for newcomers help wanted Extra attention is needed v1.2.0 Issues for v1.2.0 release labels Feb 2, 2021
@kakkoyun
Copy link
Contributor

kakkoyun commented Feb 2, 2021

Thanks, @viceice for reporting. This was something I planned for a while. Never had the time to get to it. This shouldn't be hard to achieve with goreleaser (that's what we use).

We'd really appreciate your contributions. So help wanted :)

@viceice
Copy link
Author

viceice commented Feb 2, 2021

I'll see what i can do. It currently has a low prio.

@bdebyl
Copy link
Contributor

bdebyl commented Jul 19, 2022

This seems like it was implemented as part of GitHub actions used with Goreleaser here:

However, I don't see specific Windows builds on Docker Hub for drone-cache. I'll look into this more and figure out what's missing from goreleaser to get this through

@bdebyl bdebyl added v1.4.0 Issues for v1.4.0 release and removed help wanted Extra attention is needed v1.2.0 Issues for v1.2.0 release labels Jul 19, 2022
@bdebyl
Copy link
Contributor

bdebyl commented Oct 6, 2022

Upon further investigation it seems like the upstream dependency for mattn/go-ieproxy (see here) used by the Azure Cloud provider we support in drone-cache

I am unsure if go-ieproxy#44 will fix these build issues with Drone Cache (via Goreleaser) or not, but when this is merged we can certainly try and attempt to re-enable Windows based builds.

I will use this issue to track the Windows compiling issues as well.

example failure for Windows (any ARCH):

vendor/github.com/mattn/go-ieproxy/ieproxy_windows.go:22:6: getConf redeclared in this block
	vendor/github.com/mattn/go-ieproxy/ieproxy_unix.go:6:6: other declaration of getConf
vendor/github.com/mattn/go-ieproxy/ieproxy_windows.go:28:6: reloadConf redeclared in this block
	vendor/github.com/mattn/go-ieproxy/ieproxy_unix.go:10:6: other declaration of reloadConf
vendor/github.com/mattn/go-ieproxy/ieproxy_windows.go:133:6: overrideEnvWithStaticProxy redeclared in this block
	vendor/github.com/mattn/go-ieproxy/ieproxy_unix.go:14:6: other declaration of overrideEnvWithStaticProxy
vendor/github.com/mattn/go-ieproxy/pac_windows.go:9:29: ProxyScriptConf.findProxyForURL redeclared in this block
	vendor/github.com/mattn/go-ieproxy/pac_unix.go:6:29: other declaration of findProxyForURL

@bdebyl bdebyl added bug Something isn't working and removed good first issue Good for newcomers v1.4.0 Issues for v1.4.0 release labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants