Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to precise nodePort in values.yaml if service type is NodePort #50

Open
eskombro opened this issue Feb 11, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@eskombro
Copy link
Member

eskombro commented Feb 11, 2021

In values.yaml it is possible to define the Service type. But if a user defines it as a NodePort service, there is no field in the chart to specify the nodePort, so kubernetes will allocate a random port.

In a NodePort Service, the nodePort field is defined as follows:

Screenshot 2021-02-11 at 18 48 52

But MeiliSearch chart is not prepared to let the user specify this nodePort Value in values.yaml and integrate it in the template (cf. see here).

The service template could check if the Service type is NodePort, and in that case, add the nodePort field to the Service Template.

@eskombro eskombro added good first issue Good for newcomers enhancement New feature or request labels Feb 11, 2021
bors bot added a commit that referenced this issue Nov 17, 2021
87: Support for specifying Nodeport in service r=alallema a=Thearas

# Pull Request

## What does this PR do?

Implement #50.

Co-authored-by: Thearas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants