Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update port value for startupProbe, livenessProbe, readinessProbe in meilisearc… #241

Closed
wants to merge 2 commits into from

Conversation

batchris
Copy link

@batchris batchris commented Sep 22, 2024

…h.yaml

sur les startupProbe, livenessProbe, readinessProbe, j'ai du mettre : port: 7700

sinon j'avais une erreur
'Startup probe errored: strconv.Atoi: parsing "http": invalid syntax' et le service reste innaccessible

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

….yaml

sur les startupProbe, livenessProbe, readinessProbe, j'ai du mettre : 
port: 7700

sinon j'avais une erreur 
'Startup probe errored: strconv.Atoi: parsing "http": invalid syntax'
et le service reste innaccessible
@batchris batchris changed the title Update for startupProbe, livenessProbe, readinessProbe in meilisearc… Update port value for startupProbe, livenessProbe, readinessProbe in meilisearc… Sep 22, 2024
@brunoocasali
Copy link
Member

@meilisearch sync-manifest

@brunoocasali brunoocasali added the enhancement New feature or request label Oct 2, 2024
@brunoocasali
Copy link
Member

bors merge

meili-bors bot added a commit that referenced this pull request Oct 2, 2024
241: Update port value for startupProbe, livenessProbe, readinessProbe in meilisearc… r=brunoocasali a=batchris

…h.yaml

sur les startupProbe, livenessProbe, readinessProbe, j'ai du mettre :  port: 7700

sinon j'avais une erreur 
'Startup probe errored: strconv.Atoi: parsing "http": invalid syntax' et le service reste innaccessible

# Pull Request

## Related issue
Fixes #<issue_number>

## What does this PR do?
- ...

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [ ] Have you read the contributing guidelines?
- [ ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Chris Navas <[email protected]>
Co-authored-by: brunoocasali <[email protected]>
Copy link
Contributor

meili-bors bot commented Oct 2, 2024

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"}

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

meili-bors bot added a commit that referenced this pull request Oct 2, 2024
241: Update port value for startupProbe, livenessProbe, readinessProbe in meilisearc… r=brunoocasali a=batchris

…h.yaml

sur les startupProbe, livenessProbe, readinessProbe, j'ai du mettre :  port: 7700

sinon j'avais une erreur 
'Startup probe errored: strconv.Atoi: parsing "http": invalid syntax' et le service reste innaccessible

# Pull Request

## Related issue
Fixes #<issue_number>

## What does this PR do?
- ...

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [ ] Have you read the contributing guidelines?
- [ ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Chris Navas <[email protected]>
Co-authored-by: brunoocasali <[email protected]>
Copy link
Contributor

meili-bors bot commented Oct 2, 2024

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"}

@brunoocasali
Copy link
Member

I don't know why I tried to merge this 😮‍💨

It should not be needed because the ports declaration happens before:

ports:
  - name: http
    containerPort: 7700
    protocol: TCP

Then it acts like a variable "http"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants