Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart updates which require a manual backup restore should be major updates? #201

Closed
pat-s opened this issue Sep 21, 2023 · 4 comments
Closed
Labels
documentation Improvements or additions to documentation

Comments

@pat-s
Copy link

pat-s commented Sep 21, 2023

Description
We're using meilisearch since v1.0.0 and it looks like that every minor version release requires a manual backup and restore and the update won't just work out of the box.

This becomes an issue if the chart also only releases a minor update as a lot of infra-automation tools aim to auto-merge minor and patch updates (e.g. renovate) as these release types usually indicate non-breaking changes.
Now if this happens for meilisearch the update will fail as one cannot simply update from 1.1.0 to 1.2.0 and so on. I assume this will be the case for future meilisearch releases as well?

My proposal would be to release a major version of the chart if a new meilisearch release is included which does not support auto-updating. This way, automation won't do the update and manual work is required - which at least keeps the running/old instance working.

@pat-s
Copy link
Author

pat-s commented Sep 28, 2023

Now what I described above happened with the 0.2.7 chart release, bumping to meilisearch 1.4 which does not work OOB...

@brunoocasali
Copy link
Member

As far as I remember, based on our versioning policy https://github.com/meilisearch/engine-team/blob/main/resources/versioning-policy.md yes, for every new update, you will have to make a dump and restart your infra. I agree that's not the best, but we have yet to find a solution.

So, I am keen to agree with you to release a major version of the chart for each new release of meilisearch that is not a patch.
This will be an "alert" to the users that they can't simply run a chart update, and it will work. They need to watch the changelog.

Unless @curquiza changes my mind on the subject I think we can do it for the next releases.

@curquiza
Copy link
Member

Agreed with you if this is something the community prefers!

@brunoocasali
Copy link
Member

Ok, cool, let's do it then!

I don't think we have to change it anything is more a mindset/process than a real code-change, so the next release it will start following this pattern.

Thanks for your inputs @pat-s and @curquiza ;)

@brunoocasali brunoocasali added the documentation Improvements or additions to documentation label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants