Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from random generated tokens to JWT tokens #489

Open
jpowie01 opened this issue Nov 11, 2018 · 0 comments
Open

Switch from random generated tokens to JWT tokens #489

jpowie01 opened this issue Nov 11, 2018 · 0 comments
Labels
Backend 🏭 Stuff related to Backend part. Enhancement 🌪 Things that improve our project. P1 Things with #1 Priority

Comments

@jpowie01
Copy link
Member

Current Behavior

Currently we are using itsdangerous implementation for generating tokens here:
https://github.com/jpowie01/MedTagger/blob/master/backend/medtagger/api/security.py#L61

Expected Behavior

We should move to JWT tokens with ability to revoke user tokens in separated table with blacklisted tokens:
https://realpython.com/token-based-authentication-with-flask/

This will increase MedTagger's security a little bit as now tokens that were generated for users may be used even if they log out from application.
@jpowie01 jpowie01 added Enhancement 🌪 Things that improve our project. Backend 🏭 Stuff related to Backend part. P1 Things with #1 Priority Backlog 🌍 labels Nov 11, 2018
@jpowie01 jpowie01 changed the title Switch from random generated token to JWT tokens Switch from random generated tokens to JWT tokens Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backend 🏭 Stuff related to Backend part. Enhancement 🌪 Things that improve our project. P1 Things with #1 Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpowie01