Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permenently archive a 3.x version with Enketo uplift #7836

Closed
mrjones-plip opened this issue Oct 5, 2022 · 12 comments
Closed

Permenently archive a 3.x version with Enketo uplift #7836

mrjones-plip opened this issue Oct 5, 2022 · 12 comments
Assignees
Labels
Type: Technical issue Improve something that users won't notice

Comments

@mrjones-plip
Copy link
Contributor

mrjones-plip commented Oct 5, 2022

Describe the issue
In ~60 days the one version that users can easily test their forms with the enketo uplift (7786-fix-report-label) will disappear because branches are culled from staging.dev.medicmobile.org every 90 days and it was published ~30 days ago.

As documented by this forum post, this branch makes it trivial to use docker to set up and test your forms in preparation for 4.0, but it will go away soon.

Describe the improvement you'd like
We should figure permanent way to archive this so users can continue to use medic-os to easily test their forms in docker under CHT 3.x. While Arch v3/CHT 4 will have the enketo uplift (and supports docker) this is currently not stable and presents a larger effort for app devs to continue doing what they're doing today.

Describe alternatives you've considered
Can't think of any...

Related, new enketo_upgrade_3.x branch is being worked on.

@mrjones-plip mrjones-plip added the Type: Technical issue Improve something that users won't notice label Oct 5, 2022
@mrjones-plip mrjones-plip changed the title Permenently archive an 3.x version with Enketo uplift Permenently archive n 3.x version with Enketo uplift Oct 5, 2022
@dianabarsan
Copy link
Member

How hard would it be to build a medic-os image with this branch pre-installed?

@mrjones-plip
Copy link
Contributor Author

How hard would it be to build a medic-os image with this branch pre-installed?

Let the records show that I didn't suggest this!! (though I totally thought this). 😅

I know @Hareet was opposed to new medic-os builds, but maybe we can sneak one very last one in!?!? I'll stay out of the way and defer to the experts.

@mrjones-plip mrjones-plip changed the title Permenently archive n 3.x version with Enketo uplift Permenently archive a 3.x version with Enketo uplift Oct 6, 2022
@jkuester
Copy link
Contributor

jkuester commented Oct 6, 2022

Just leaving a reminder that we should include documentation for whatever we decide to do in the upgrade guide: medic/cht-docs#806

@jkuester
Copy link
Contributor

https://github.com/medic/cht-core/tree/enketo_upgrade_3.x now contains what I believe to be the best Enketo code on 3.x.

It includes the following cherrypicked on top of the 3.17.x branch:

@mrjones-plip
Copy link
Contributor Author

awesome!

@garethbowen
Copy link
Member

@jkuester Can we close this issue off now or is there more to be done?

@jkuester
Copy link
Contributor

😭 @garethbowen we have almost started!

https://github.com/medic/cht-core/tree/enketo_upgrade_3.x is in good shape, but its build artifacts will be deleted after 90 days. I am looking into possibly cutting a feature release from this branch to keep it around permanently. That was my plan for this afternoon, but have kinda gotten bogged down in PRs... Should be able to close this soon, though!

@jkuester jkuester moved this from Todo to Ready for AT in Product Team Activities Nov 30, 2022
@jkuester
Copy link
Contributor

This is ready for AT!

I have created a new feature release: https://github.com/medic/cht-core/releases/tag/3.17.0-FR-enketo-upgrade-beta.1

This should be a permanently accessible build of the code from https://github.com/medic/cht-core/tree/enketo_upgrade_3.x that anyone on 3.x can upgrade their instance to use.

To install the feature release using horti run:

COUCH_URL=https://medic:[email protected]:8443/medic horti --local --install=3.17.0-FR-enketo-upgrade-beta.1

The big things to test on this FR is just that the basic form functionality is still intact as well as new Enketo features also work:

  • The latest default config from master has forms that use the add-date function. These should work on this FR.
  • The enketo_widgets form should work on this FR.

@jkuester
Copy link
Contributor

To be clear, no changes have been made to the main/master branches on any of our repos for this issue. After investigating various options, I concluded that a simple feature release following this basic process was going to be sufficient to achieve what we wanted here!

@mrjones-plip
Copy link
Contributor Author

I concluded that a simple feature release following this basic process was going to be sufficient to achieve what we wanted here!

simplicity FTW - love it!

@tatilepizs
Copy link
Contributor

Test details

Config: Default -> uploaded the config from master branch (cht v4.0)
Environment: Local
Platform: WebApp
Browser: Chrome
cht-core version: 3.17.0-FR-enketo-upgrade-beta.1 -> installed using horti


Tested using the following forms and everything worked as expected.

  • Create and edit district_hospital , health_center, clinic and person
  • Pregnancy registration
  • Pregnancy danger sign follow-up
  • Health facility ANC reminder
  • Pregnancy home visit
  • Delivery
  • Postnatal danger sign follow-up - mother
  • Postnatal danger sign follow-up - baby
  • Death report
  • Undo death report
  • enketo_widgets

@tatilepizs tatilepizs moved this from AT in Progress to Ready to Merge in Product Team Activities Dec 5, 2022
@jkuester
Copy link
Contributor

jkuester commented Dec 5, 2022

Closing as the updated version of Enekto will now remain available for testing on the feature release: https://github.com/medic/cht-core/releases/tag/3.17.0-FR-enketo-upgrade-beta.1

@jkuester jkuester closed this as completed Dec 5, 2022
Repository owner moved this from Ready to Merge to Done in Product Team Activities Dec 5, 2022
@mrjones-plip mrjones-plip moved this from Done to This Week's commitments in Product Team Activities Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Technical issue Improve something that users won't notice
Projects
Archived in project
Development

No branches or pull requests

5 participants