Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms show error message upon opening #5980

Closed
ngaruko opened this issue Sep 24, 2019 · 4 comments · Fixed by #7256
Closed

Forms show error message upon opening #5980

ngaruko opened this issue Sep 24, 2019 · 4 comments · Fixed by #7256
Assignees
@ngaruko @jkuester
Labels
Enketo Affects Enketo forms Type: Bug Fix something that isn't working as intended
Milestone
4.0.0

Comments

@ngaruko
Copy link
Contributor

ngaruko commented Sep 24, 2019

Describe the bug
Some forms (eg New Pregnancy)come with This field is required error message upon opening.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'reports' page
  2. Click on 'Submit report'
  3. Pick up for like New Pregnancy or Pregnancy visit
  4. See This field is required error on the form.

Expected behavior
The form should be 'clean', only flag the error message when the user attempt to proceed without selecting the patient's name.

Screenshots
image

Environment

  • Instance: local
  • Browser: Firefox, Chrome
  • Client platform: MacOS
  • App: webapp
  • Version: 3.6.* but has been this way for a while
@ngaruko ngaruko added the Type: Bug Fix something that isn't working as intended label Sep 24, 2019
@dianabarsan
Copy link
Member

@jkuester I'm wondering if this changes with latest Enketo updates.

@jkuester jkuester added the Enketo Affects Enketo forms label May 19, 2022
@jkuester
Copy link
Contributor

Just want to confirm that I have tested both the standard pregnancy and pregnancy_visit forms. I was able to recreate the behavior on 3.15 but not on https://github.com/medic/cht-core/tree/6345-enketo-uplift so I think it is safe to say this has been fixed by the Enketo updates!

@jkuester jkuester mentioned this issue May 19, 2022
Merged
5 tasks
@garethbowen garethbowen added this to the 4.0.0 milestone May 19, 2022
@jkuester
Copy link
Contributor

@medic/quality-assurance this is ready for AT on #7256

@ngaruko
Copy link
Contributor Author

ngaruko commented Jul 27, 2022

Looking good at the moment
image

@ngaruko ngaruko self-assigned this Jul 27, 2022
@garethbowen garethbowen moved this to Ready to Merge in Product Team Activities Jul 31, 2022
Repository owner moved this from Ready to Merge to Done in Product Team Activities Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngaruko ngaruko

@jkuester jkuester

Labels
Enketo Affects Enketo forms Type: Bug Fix something that isn't working as intended
Projects
Product Team Activities
Status: Done
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

6345 - Uplift to enketo-core version 5.18.1 medic/cht-core
4 participants
@garethbowen @ngaruko @jkuester @dianabarsan