Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review #58

Open
9 of 13 tasks
paulgirard opened this issue Jun 25, 2019 · 0 comments
Open
9 of 13 tasks

review #58

paulgirard opened this issue Jun 25, 2019 · 0 comments

Comments

@paulgirard
Copy link
Member

paulgirard commented Jun 25, 2019

  • automatically create branch at login
  • in general make the required fields appear on top of the form
  • select component : default values should be empty
  • in source form, add suggestions using existing values from the current source table
  • change labels to indicate the fix tresults in summary using LABEL_FIELDS_FK_SOLVED constant
  • change the name of the download flow fils add a "_ongoing_corrections" to the name before ext
  • make the required error disaply message mor explicit : add the fieldname and if possible the row number
  • pre-fill modified_currency in exchange_rates table after FK validation fail
    - [ ] Cannot assign to read only property of array error
  • add a confirmation modal if an error has been solved but without using the confirm this fix button and a navigation button is pressed next error / prev error / back to summary

second round to make it even better

  • add a "discard modification" button close to "confirm this fix" to let the user cancel what she started to be able to move to next error without confirming
  • if there are two year format errors, the second one will take the fixedValue of the first one as a default value when automatically opening it after confirming the first error fix
  • add a loading gif when uploading to github cause it takes a long time and we want to make sure the user will understand he has to wait. Maybe adding a message : this will take a few minutes ? There is no way we can provide her with more info while uploading I guess ?
  • add a logout button at the first step to let the user change his nickname
mydu added a commit that referenced this issue Jun 25, 2019
mydu added a commit that referenced this issue Jun 26, 2019
mydu added a commit that referenced this issue Jun 26, 2019
mydu added a commit that referenced this issue Jun 27, 2019
mydu added a commit that referenced this issue Jun 28, 2019
mydu added a commit that referenced this issue Jul 1, 2019
mydu added a commit that referenced this issue Jul 2, 2019
mydu added a commit that referenced this issue Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant