Skip to content

Commit

Permalink
Fix camlp4 on non-natdynlink systems
Browse files Browse the repository at this point in the history
camlp4's all target depends on ocaml-native-dynlink, not just
ocaml-native. This in particular affects Cygwin when the flexdll package
has not been installed (which has ocamlopt but does not have natdynlink).
  • Loading branch information
dra27 committed Jan 8, 2018
1 parent abef6f7 commit e72325d
Show file tree
Hide file tree
Showing 20 changed files with 310 additions and 24 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
From f0ea53725465260556832398096cef8d3f20b49d Mon Sep 17 00:00:00 2001
From: David Allsopp <[email protected]>
Date: Mon, 8 Jan 2018 12:59:08 +0000
Subject: [PATCH] Fix make byte for systems with no natdynlink

2a31a83 builds a native-code preprocessor if ocamlbuild supports native
code. However, it's possible to have systems which support native code but
don't have natdynlink (e.g. Cygwin without flexdll support) and in this
case the build fails.

Signed-off-by: David Allsopp <[email protected]>
---
myocamlbuild.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/myocamlbuild.ml b/myocamlbuild.ml
index 7264df134..ecaac916f 100644
--- a/myocamlbuild.ml
+++ b/myocamlbuild.ml
@@ -76,7 +76,7 @@ let () =
else
let exe =
"camlp4boot" ^
- if !Options.native_plugin then
+ if C.ocamlnat then
(* If we are using a native plugin, we might as well use a native
preprocessor. *)
".native"
5 changes: 3 additions & 2 deletions packages/camlp4/camlp4.4.02+1/opam
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ homepage: "https://github.com/ocaml/camlp4"
license: "LGPLv2"
build: [
["./configure" "--bindir=%{bin}%" "--libdir=%{lib}%/ocaml" "--pkgdir=%{lib}%"]
[make "all"] {ocaml-native}
[make "byte"] {!ocaml-native}
[make "all"] {ocaml-native-dynlink}
[make "byte"] {!ocaml-native-dynlink}
]
depends: [
"ocamlfind"
Expand All @@ -25,6 +25,7 @@ remove: [
"%{bin}%/camlp4o.opt" "%{bin}%/camlp4oof.opt" "%{bin}%/camlp4r.opt"
]
]
patches: [ "f0ea53725465260556832398096cef8d3f20b49d.patch" ]
available: [ (!preinstalled) & (ocaml-version >= "4.02") & (ocaml-version < "4.03") ]
bug-reports: "https://github.com/ocaml/camlp4/issues"
dev-repo: "https://github.com/ocaml/camlp4.git"
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
From f0ea53725465260556832398096cef8d3f20b49d Mon Sep 17 00:00:00 2001
From: David Allsopp <[email protected]>
Date: Mon, 8 Jan 2018 12:59:08 +0000
Subject: [PATCH] Fix make byte for systems with no natdynlink

2a31a83 builds a native-code preprocessor if ocamlbuild supports native
code. However, it's possible to have systems which support native code but
don't have natdynlink (e.g. Cygwin without flexdll support) and in this
case the build fails.

Signed-off-by: David Allsopp <[email protected]>
---
myocamlbuild.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/myocamlbuild.ml b/myocamlbuild.ml
index 7264df134..ecaac916f 100644
--- a/myocamlbuild.ml
+++ b/myocamlbuild.ml
@@ -76,7 +76,7 @@ let () =
else
let exe =
"camlp4boot" ^
- if !Options.native_plugin then
+ if C.ocamlnat then
(* If we are using a native plugin, we might as well use a native
preprocessor. *)
".native"
5 changes: 3 additions & 2 deletions packages/camlp4/camlp4.4.02+2/opam
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ homepage: "https://github.com/ocaml/camlp4"
license: "LGPLv2"
build: [
["./configure" "--bindir=%{bin}%" "--libdir=%{lib}%/ocaml" "--pkgdir=%{lib}%"]
[make "all"] {ocaml-native}
[make "byte"] {!ocaml-native}
[make "all"] {ocaml-native-dynlink}
[make "byte"] {!ocaml-native-dynlink}
]
depends: [
"ocamlfind"
Expand All @@ -25,6 +25,7 @@ remove: [
"%{bin}%/camlp4o.opt" "%{bin}%/camlp4oof.opt" "%{bin}%/camlp4r.opt"
]
]
patches: [ "f0ea53725465260556832398096cef8d3f20b49d.patch" ]
available: [ (!preinstalled) & (ocaml-version >= "4.02") & (ocaml-version < "4.03") ]
bug-reports: "https://github.com/ocaml/camlp4/issues"
dev-repo: "https://github.com/ocaml/camlp4.git"
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
From f0ea53725465260556832398096cef8d3f20b49d Mon Sep 17 00:00:00 2001
From: David Allsopp <[email protected]>
Date: Mon, 8 Jan 2018 12:59:08 +0000
Subject: [PATCH] Fix make byte for systems with no natdynlink

2a31a83 builds a native-code preprocessor if ocamlbuild supports native
code. However, it's possible to have systems which support native code but
don't have natdynlink (e.g. Cygwin without flexdll support) and in this
case the build fails.

Signed-off-by: David Allsopp <[email protected]>
---
myocamlbuild.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/myocamlbuild.ml b/myocamlbuild.ml
index 7264df134..ecaac916f 100644
--- a/myocamlbuild.ml
+++ b/myocamlbuild.ml
@@ -76,7 +76,7 @@ let () =
else
let exe =
"camlp4boot" ^
- if !Options.native_plugin then
+ if C.ocamlnat then
(* If we are using a native plugin, we might as well use a native
preprocessor. *)
".native"
5 changes: 3 additions & 2 deletions packages/camlp4/camlp4.4.02+3/opam
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ homepage: "https://github.com/ocaml/camlp4"
license: "LGPLv2"
build: [
["./configure" "--bindir=%{bin}%" "--libdir=%{lib}%/ocaml" "--pkgdir=%{lib}%"]
[make "all"] {ocaml-native}
[make "byte"] {!ocaml-native}
[make "all"] {ocaml-native-dynlink}
[make "byte"] {!ocaml-native-dynlink}
]
depends: [
"ocamlfind"
Expand All @@ -25,6 +25,7 @@ remove: [
"%{bin}%/camlp4o.opt" "%{bin}%/camlp4oof.opt" "%{bin}%/camlp4r.opt"
]
]
patches: [ "f0ea53725465260556832398096cef8d3f20b49d.patch" ]
available: [ (!preinstalled) & (ocaml-version >= "4.02") & (ocaml-version < "4.03") ]
bug-reports: "https://github.com/ocaml/camlp4/issues"
dev-repo: "https://github.com/ocaml/camlp4.git"
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
From f0ea53725465260556832398096cef8d3f20b49d Mon Sep 17 00:00:00 2001
From: David Allsopp <[email protected]>
Date: Mon, 8 Jan 2018 12:59:08 +0000
Subject: [PATCH] Fix make byte for systems with no natdynlink

2a31a83 builds a native-code preprocessor if ocamlbuild supports native
code. However, it's possible to have systems which support native code but
don't have natdynlink (e.g. Cygwin without flexdll support) and in this
case the build fails.

Signed-off-by: David Allsopp <[email protected]>
---
myocamlbuild.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/myocamlbuild.ml b/myocamlbuild.ml
index 7264df134..ecaac916f 100644
--- a/myocamlbuild.ml
+++ b/myocamlbuild.ml
@@ -76,7 +76,7 @@ let () =
else
let exe =
"camlp4boot" ^
- if !Options.native_plugin then
+ if C.ocamlnat then
(* If we are using a native plugin, we might as well use a native
preprocessor. *)
".native"
5 changes: 3 additions & 2 deletions packages/camlp4/camlp4.4.02+4/opam
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ homepage: "https://github.com/ocaml/camlp4"
license: "LGPLv2"
build: [
["./configure" "--bindir=%{bin}%" "--libdir=%{lib}%/ocaml" "--pkgdir=%{lib}%"]
[make "all"] {ocaml-native}
[make "byte"] {!ocaml-native}
[make "all"] {ocaml-native-dynlink}
[make "byte"] {!ocaml-native-dynlink}
]
depends: [
"ocamlfind"
Expand All @@ -25,6 +25,7 @@ remove: [
"%{bin}%/camlp4o.opt" "%{bin}%/camlp4oof.opt" "%{bin}%/camlp4r.opt"
]
]
patches: [ "f0ea53725465260556832398096cef8d3f20b49d.patch" ]
available: [ (!preinstalled) & (ocaml-version >= "4.02") & (ocaml-version < "4.03") ]
bug-reports: "https://github.com/ocaml/camlp4/issues"
dev-repo: "https://github.com/ocaml/camlp4.git"
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
From f0ea53725465260556832398096cef8d3f20b49d Mon Sep 17 00:00:00 2001
From: David Allsopp <[email protected]>
Date: Mon, 8 Jan 2018 12:59:08 +0000
Subject: [PATCH] Fix make byte for systems with no natdynlink

2a31a83 builds a native-code preprocessor if ocamlbuild supports native
code. However, it's possible to have systems which support native code but
don't have natdynlink (e.g. Cygwin without flexdll support) and in this
case the build fails.

Signed-off-by: David Allsopp <[email protected]>
---
myocamlbuild.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/myocamlbuild.ml b/myocamlbuild.ml
index 7264df134..ecaac916f 100644
--- a/myocamlbuild.ml
+++ b/myocamlbuild.ml
@@ -76,7 +76,7 @@ let () =
else
let exe =
"camlp4boot" ^
- if !Options.native_plugin then
+ if C.ocamlnat then
(* If we are using a native plugin, we might as well use a native
preprocessor. *)
".native"
5 changes: 3 additions & 2 deletions packages/camlp4/camlp4.4.02+6/opam
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ homepage: "https://github.com/ocaml/camlp4"
license: "LGPLv2"
build: [
["./configure" "--bindir=%{bin}%" "--libdir=%{lib}%/ocaml" "--pkgdir=%{lib}%"]
[make "all"] {ocaml-native}
[make "byte"] {!ocaml-native}
[make "all"] {ocaml-native-dynlink}
[make "byte"] {!ocaml-native-dynlink}
]
depends: [
"ocamlbuild" {build}
Expand All @@ -24,6 +24,7 @@ remove: [
"%{bin}%/camlp4o.opt" "%{bin}%/camlp4oof.opt" "%{bin}%/camlp4r.opt"
]
]
patches: [ "f0ea53725465260556832398096cef8d3f20b49d.patch" ]
available: [ (!preinstalled) & (ocaml-version >= "4.02") & (ocaml-version < "4.03") ]
bug-reports: "https://github.com/ocaml/camlp4/issues"
dev-repo: "https://github.com/ocaml/camlp4.git"
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
From f0ea53725465260556832398096cef8d3f20b49d Mon Sep 17 00:00:00 2001
From: David Allsopp <[email protected]>
Date: Mon, 8 Jan 2018 12:59:08 +0000
Subject: [PATCH] Fix make byte for systems with no natdynlink

2a31a83 builds a native-code preprocessor if ocamlbuild supports native
code. However, it's possible to have systems which support native code but
don't have natdynlink (e.g. Cygwin without flexdll support) and in this
case the build fails.

Signed-off-by: David Allsopp <[email protected]>
---
myocamlbuild.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/myocamlbuild.ml b/myocamlbuild.ml
index 7264df134..ecaac916f 100644
--- a/myocamlbuild.ml
+++ b/myocamlbuild.ml
@@ -76,7 +76,7 @@ let () =
else
let exe =
"camlp4boot" ^
- if !Options.native_plugin then
+ if C.ocamlnat then
(* If we are using a native plugin, we might as well use a native
preprocessor. *)
".native"
6 changes: 3 additions & 3 deletions packages/camlp4/camlp4.4.02+7/opam
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ homepage: "https://github.com/ocaml/camlp4"
license: "LGPLv2"
build: [
["./configure" "--bindir=%{bin}%" "--libdir=%{lib}%/ocaml" "--pkgdir=%{lib}%"]
[make "all"] {ocaml-native}
[make "byte"] {!ocaml-native}
[make "all"] {ocaml-native-dynlink}
[make "byte"] {!ocaml-native-dynlink}
]
depends: [
"conf-which" {build}
Expand All @@ -24,7 +24,7 @@ remove: [
"%{bin}%/camlp4o.opt" "%{bin}%/camlp4oof.opt" "%{bin}%/camlp4r.opt"
]
]
patches: [ "termux.patch" ]
patches: [ "termux.patch" "f0ea53725465260556832398096cef8d3f20b49d.patch" ]
available: [ (!preinstalled) & (ocaml-version >= "4.02") & (ocaml-version < "4.03") ]
bug-reports: "https://github.com/ocaml/camlp4/issues"
dev-repo: "https://github.com/ocaml/camlp4.git"
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
From f0ea53725465260556832398096cef8d3f20b49d Mon Sep 17 00:00:00 2001
From: David Allsopp <[email protected]>
Date: Mon, 8 Jan 2018 12:59:08 +0000
Subject: [PATCH] Fix make byte for systems with no natdynlink

2a31a83 builds a native-code preprocessor if ocamlbuild supports native
code. However, it's possible to have systems which support native code but
don't have natdynlink (e.g. Cygwin without flexdll support) and in this
case the build fails.

Signed-off-by: David Allsopp <[email protected]>
---
myocamlbuild.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/myocamlbuild.ml b/myocamlbuild.ml
index 7264df134..ecaac916f 100644
--- a/myocamlbuild.ml
+++ b/myocamlbuild.ml
@@ -76,7 +76,7 @@ let () =
else
let exe =
"camlp4boot" ^
- if !Options.native_plugin then
+ if C.ocamlnat then
(* If we are using a native plugin, we might as well use a native
preprocessor. *)
".native"
6 changes: 3 additions & 3 deletions packages/camlp4/camlp4.4.03+1/opam
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ homepage: "https://github.com/ocaml/camlp4"
license: "LGPLv2"
build: [
["./configure" "--bindir=%{bin}%" "--libdir=%{lib}%/ocaml" "--pkgdir=%{lib}%"]
[make "all"] {ocaml-native}
[make "byte"] {!ocaml-native}
[make "all"] {ocaml-native-dynlink}
[make "byte"] {!ocaml-native-dynlink}
]
depends: [
"ocamlbuild" {build}
Expand All @@ -24,7 +24,7 @@ remove: [
"%{bin}%/camlp4o.opt" "%{bin}%/camlp4oof.opt" "%{bin}%/camlp4r.opt"
]
]
patches: [ "termux.patch" ]
patches: [ "termux.patch" "f0ea53725465260556832398096cef8d3f20b49d.patch" ]
available: [ (!preinstalled) & (ocaml-version >= "4.03") & (ocaml-version < "4.04") ]
bug-reports: "https://github.com/ocaml/camlp4/issues"
dev-repo: "https://github.com/ocaml/camlp4.git"
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
From f0ea53725465260556832398096cef8d3f20b49d Mon Sep 17 00:00:00 2001
From: David Allsopp <[email protected]>
Date: Mon, 8 Jan 2018 12:59:08 +0000
Subject: [PATCH] Fix make byte for systems with no natdynlink

2a31a83 builds a native-code preprocessor if ocamlbuild supports native
code. However, it's possible to have systems which support native code but
don't have natdynlink (e.g. Cygwin without flexdll support) and in this
case the build fails.

Signed-off-by: David Allsopp <[email protected]>
---
myocamlbuild.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/myocamlbuild.ml b/myocamlbuild.ml
index 7264df134..ecaac916f 100644
--- a/myocamlbuild.ml
+++ b/myocamlbuild.ml
@@ -76,7 +76,7 @@ let () =
else
let exe =
"camlp4boot" ^
- if !Options.native_plugin then
+ if C.ocamlnat then
(* If we are using a native plugin, we might as well use a native
preprocessor. *)
".native"
6 changes: 3 additions & 3 deletions packages/camlp4/camlp4.4.04+1/opam
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ license: "LGPLv2"
build: [
["./configure" "--bindir=%{bin}%" "--libdir=%{lib}%/ocaml" "--pkgdir=%{lib}%"]
[make "clean"]
[make "all"] {ocaml-native}
[make "byte"] {!ocaml-native}
[make "all"] {ocaml-native-dynlink}
[make "byte"] {!ocaml-native-dynlink}
]
depends: [
"ocamlbuild" {build}
Expand All @@ -24,7 +24,7 @@ remove: [
"%{bin}%/camlp4prof"]
]

patches: [ "termux.patch" ]
patches: [ "termux.patch" "f0ea53725465260556832398096cef8d3f20b49d.patch" ]
available: [ (!preinstalled) & (ocaml-version >= "4.04") & (ocaml-version < "4.05") ]
bug-reports: "https://github.com/ocaml/camlp4/issues"
dev-repo: "https://github.com/ocaml/camlp4.git"
Loading

0 comments on commit e72325d

Please sign in to comment.