feat: accept JSX.Element for various dropdown items (#129)

* Update SandpackPreset label to accept JSX.Element * Update BlockTypeSelect.tsx to accept JSX.Element in select items * Update select.tsx to accept JSX.Element in SelectProps * Update toolbar.tsx to accept JSX.Element in dropdown
mdx-editor · Oct 17, 2023 · ec8eca1 · ec8eca1
1 parent 5de52ad
commit ec8eca1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/plugins/sandpack/index.tsx b/src/plugins/sandpack/index.tsx
@@ -18,7 +18,7 @@ export interface SandpackPreset {
   /**
    * The label of the preset, displayed in the sandpack button dropdown.
    */
-  label: string
+  label: string | JSX.Element
   /**
    * The meta string that will be used to identify the preset from the fenced code block. e.g. "live react"
    */

diff --git a/src/plugins/toolbar/components/BlockTypeSelect.tsx b/src/plugins/toolbar/components/BlockTypeSelect.tsx
@@ -19,7 +19,7 @@ export const BlockTypeSelect = () => {
   if (!hasQuote && !hasHeadings) {
     return null
   }
-  const items: { label: string; value: BlockType }[] = [{ label: 'Paragraph', value: 'paragraph' }]
+  const items: { label: string | JSX.Element; value: BlockType }[] = [{ label: 'Paragraph', value: 'paragraph' }]
 
   if (hasQuote) {
     items.push({ label: 'Quote', value: 'quote' })

diff --git a/src/plugins/toolbar/primitives/select.tsx b/src/plugins/toolbar/primitives/select.tsx
@@ -88,7 +88,7 @@ export interface SelectProps<T extends string> {
   onChange: (value: T) => void
   triggerTitle: string
   placeholder: string
-  items: ({ label: string; value: T } | 'separator')[]
+  items: ({ label: string | JSX.Element; value: T } | 'separator')[]
 }
 
 /**

diff --git a/src/plugins/toolbar/primitives/toolbar.tsx b/src/plugins/toolbar/primitives/toolbar.tsx
@@ -192,7 +192,7 @@ export interface ButtonOrDropdownButtonProps<T extends string> {
     /**
      * The label to show in the dropdown.
      */
-    label: string
+    label: string | JSX.Element
   }[]
 }
-Original file line number
+Diff line change
@@ Expand Up @@
         /**
          * The label to show in the dropdown.
          */
-        label: string
+        label: string | JSX.Element
       }[]
     }
@@ Expand Down @@