Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename css.types.calc-constant to css.types.calc-keyword #25395

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Dec 12, 2024

Summary

This has been renamed in the spec and on MDN.

Open questions

Related issues

Fixes #24036

@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:s [PR only] 7-24 LoC changed labels Dec 12, 2024
@bsmth
Copy link
Member Author

bsmth commented Dec 12, 2024

CC @ddbeck @LeoMcA

@ddbeck
Copy link
Collaborator

ddbeck commented Dec 12, 2024

Does web-features:calc-constants need to be renamed? See https://github.com/web-platform-dx/web-features/blob/main/features/calc-constants.yml

I don't think so, no. We could change the display name or description for the feature, but ID stability is good, especially when the actual substance of the feature hasn't changed.

@bsmth
Copy link
Member Author

bsmth commented Dec 12, 2024

Thanks, I agree, fwiw. Shall I send in a PR for the name and description changes?

@ddbeck
Copy link
Collaborator

ddbeck commented Dec 13, 2024

Shall I send in a PR for the name and description changes?

That would be very welcome, yes!

@bsmth
Copy link
Member Author

bsmth commented Dec 13, 2024

Thanks, all. Merging now and sending in a follow-up to web-features shortly

@bsmth bsmth merged commit 1d69131 into mdn:main Dec 13, 2024
8 checks passed
@bsmth bsmth deleted the 24036-calc-constant branch December 13, 2024 09:20
@mdn-bot mdn-bot mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css.types.calc-constant - Rename to calc-keyword
3 participants