Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exact version for cloneInto and exportFunction #24521

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

danielhjacobs
Copy link
Contributor

@danielhjacobs danielhjacobs commented Sep 25, 2024

According to https://blog.mozilla.org/addons/2014/04/10/changes-to-unsafewindow-for-the-add-on-sdk/#comments, this was added in Firefox 30.

Summary

These newly added browser support table records were added in #22767 without a version number.

Test results and supporting details

Not tested, but see the below blog which seems to indicate that this was added in Firefox 30:

https://blog.mozilla.org/addons/2014/04/10/changes-to-unsafewindow-for-the-add-on-sdk/

Requesting review from @Rob--W and/or @rebloor

Related issues

openwebdocs/project#206

@github-actions github-actions bot added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Sep 25, 2024
@danielhjacobs
Copy link
Contributor Author

This needs the "KR: Real BCD" label

@queengooborg queengooborg added the KR: Real BCD 🔑 Key Result: Eliminate true/null values and replace them with "real" values. label Sep 25, 2024
@queengooborg queengooborg merged commit e6499d2 into mdn:main Sep 25, 2024
5 checks passed
@danielhjacobs danielhjacobs deleted the patch-1 branch September 25, 2024 18:21
@Rob--W
Copy link
Member

Rob--W commented Sep 25, 2024

This data is incorrect. Please wait for review from webextensions people before merging BCD claims.

This was added in Firefox 49: https://bugzilla.mozilla.org/show_bug.cgi?id=1280482

@queengooborg
Copy link
Collaborator

Sorry @Rob--W, this was important to land for our real values goal. Please feel free to open a follow-up PR and I will merge it!

@Rob--W
Copy link
Member

Rob--W commented Sep 25, 2024

I can currently not edit code (from my phone). I'll open a PR later ix nobody got to it before me.

The PR is straightforward - it would be this PR, except with 49 instead of 30.

@danielhjacobs
Copy link
Contributor Author

Opened #24529

@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Sep 25, 2024

My other most recent two PRs are also meant to help with the real values goal: #24525 and #24527. With those merged and all the KR: Real BCD 🔑 Key Result: Eliminate true/null values and replace them with "real" values. PRs merged, the real values goal should be complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions KR: Real BCD 🔑 Key Result: Eliminate true/null values and replace them with "real" values.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants