Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html.elements.video - did Safari drop support for disablepictureinpicture? #24399

Open
joshkadis opened this issue Sep 9, 2024 · 1 comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML

Comments

@joshkadis
Copy link

joshkadis commented Sep 9, 2024

What type of issue is this?

Other

What information was incorrect, unhelpful, or incomplete?

It looks like Safari has removed support for the <video disablepictureinpicture> attribute

What browsers does this problem apply to, if applicable?

Safari

What did you expect to see?

  • Adding the disablepictureinpicture attribute to a <video> element should remove the UI to enter picture-in-picture mode for a HTML video player

Did you test this? If so, how?

Using the HTML demo on the MDN documentation page: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video

Here are the steps I used in the video. This was with Safari Version 17.6 (18618.3.11.11.6, 18618)

  1. Show that PiP is enabled by default
  2. Remove controls attr to confirm that the <video> element is recreated accurately when input changes
  3. Add disablepictureinpicture attribute
  4. Show that PiP is not disabled
Screen.Recording.2024-09-09.at.3.30.22.PM.mov

Can you link to any release notes, bugs, pull requests, or MDN pages related to this?

No response

Do you have anything more you want to share?

This video shows the same steps working as expected in Chrome Version 128.0.6613.120

Screen.Recording.2024-09-09.at.3.39.43.PM.mov

One more thing of interest

This is an edge case but it might be worth noting that it is possible to disable picture-in-picture video globally inside a WKWebView in iOS using the WKWebViewConfiguration. allowsPictureInPictureMediaPlayback property

MDN URL

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video

MDN metadata

MDN page report details
  • Query: html.elements.video
  • Report started: 2024-09-09T19:22:05.339Z
@queengooborg queengooborg added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Sep 9, 2024
@SamB
Copy link
Contributor

SamB commented Oct 12, 2024

Well, according to https://w3c.github.io/picture-in-picture/#disable-pip, the browser "MAY" refrain from doing Picture-in-Picture stuff when that's set, but is not obligated to do so, so 🤷 I guess it still counts as supported as long as the attribute is reflected properly between IDL and content?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

No branches or pull requests

3 participants