Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range linter: Disallow ranged values after 2020-01-01 #23991

Open
2 tasks done
Elchi3 opened this issue Jul 30, 2024 · 3 comments
Open
2 tasks done

Range linter: Disallow ranged values after 2020-01-01 #23991

Elchi3 opened this issue Jul 30, 2024 · 3 comments
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.

Comments

@Elchi3
Copy link
Member

Elchi3 commented Jul 30, 2024

What type of issue is this?

Linter issue

What is the issue?

Ranged values are currently allowed for browser versions released two years or earlier.

What behavior were you expecting?

If you set the linter to four years or earlier, it still passes. We should enforce that, so that we can make the guarantee that BCD will always report a real (non-ranged) version for as many years as possible.

What version(s) of BCD is the issue present in?

  • The current BCD release
  • The current version of the main branch

Do you have anything more you want to share?

It doesn't pass for:

  • 5 years: 832 errors (≤79 for Edge, ≤83 for Chrome, ≤72 for Firefox, and ≤13.1 for Safari would no longer be allowed)
  • 6 years: 913 errors (≤18 for Edge would no longer be allowed)
  • 7 years: 930 errors
  • 8 years: 953 errors
  • 9 years: 957 errors
  • 10 years: 1793 errors (≤37 for WebView Android would no longer be allowed)

cc @foolip @ddbeck

@ddbeck
Copy link
Collaborator

ddbeck commented Jul 30, 2024

We should enforce that, so that we can make the guarantee that BCD will always report a real (non-ranged) version for as many years as possible.

Agreed. Though I'd like to suggest going one step further and pinning those versions that define the 4-year cut off, rather than having a rolling X-year window. That way no new uncertainties would emerge (e.g., a year from now, you wouldn't be allowed to add a ranged value to a 2020 release).

@Elchi3
Copy link
Member Author

Elchi3 commented Jul 30, 2024

For reference, Philip and Daniel discussed using a cut off before: #19146 (review)

@queengooborg queengooborg added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Jul 31, 2024
@queengooborg
Copy link
Contributor

Unfortunately, a recent update to the web extensions data has now introduced a range that is within two years, so we are no longer able to switch to a longer date at this time. Currently, it is only one single range, so we may be able to prioritize researching a proper version number and replace the range.

@Elchi3 Elchi3 changed the title Range linter: Set to four years Range linter: Disallow ranged values after 2020-01-01 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

No branches or pull requests

3 participants