-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css.properties.object-position - BCD on this doesn't cover support in iframe #23586
Comments
… feature This PR adds the missing `applies_to_iframe_elements` member of the `object-position` CSS property. This fixes mdn#23586, which contains the supporting evidence for this change. Additional Notes: The test code was copied and adapted to a local server, then manually run on Firefox 36 and old Chrome/Safari versions to confirm support.
#23631 purports to resolve this, but it does so in an unclear way for And now there's a conflicting story:
Taken together, this suggests there's some set of replaced elements that are required and some that are optional. Nowhere does BCD say which are optional and which are required. The only thing I'm certain of is that I'd prefer to see one of the following things happen:
Whatever happens, I'd like to see symmetrical changes to See also web-platform-dx/web-features#1972. |
For tracking down support, WPT has some test cases- https://wpt.fyi/results/css/css-images?label=master&label=stable&aligned&q=object-position. These are tests for canvas, embed, image, object, and video. Regrettably, it looks like many of the tests are false negatives for Chrome due to image fuzziness, so it will need manual testing as well. |
#25354 did the "revert" part of #23586 (comment); what remains is to create subfeatures for each of the replaced elements (and test and populate that data). |
What type of issue is this?
Missing compatibility data
What information was incorrect, unhelpful, or incomplete?
Related to mdn/content#32474 (comment)
The property doesn't work on iframes in Chromium-based browsers and Safari. But it does work in Firefox. In the OWD weekly meeting, it was decided that BCD needs to cover the iframe entry for the
object-position
property.What browsers does this problem apply to, if applicable?
Chromium (Chrome, Edge 79+, Opera, Samsung Internet), Safari
What did you expect to see?
In the
object-fit
BCD entry, showiframe
is supported in Firefox and not in other browsers.Or in the
iframe
BCD entry, showobject-fit
is supported only in Firefox.Did you test this? If so, how?
Run the following playground demo in various browsers.
https://developer.mozilla.org/en-US/play?id=M%2BIuRXx6jXT3WN%2FzFjlc5FQ1p%2B8VB0qGSpBnv%2F4B8bTvJRCQtdgRm9Qi%2BaXMV3jGMLkxAnciNkCPtL9a
Can you link to any release notes, bugs, pull requests, or MDN pages related to this?
No response
Do you have anything more you want to share?
No response
MDN URL
https://developer.mozilla.org/en-US/docs/Web/CSS/object-position
MDN metadata
MDN page report details
css.properties.object-position
The text was updated successfully, but these errors were encountered: