Skip to content

Commit

Permalink
Merge pull request #288 from mdgspace/temp
Browse files Browse the repository at this point in the history
chore: changes flutter version
  • Loading branch information
am-casper committed Oct 9, 2024
2 parents 1829b3b + 095b4ab commit f603a96
Show file tree
Hide file tree
Showing 13 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- uses: subosito/flutter-action@v2
with:
channel: "stable"
flutter-version: 3.19.0
flutter-version: 3.24.x

# Get flutter dependencies.
- run: flutter pub get
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: subosito/flutter-action@v2
with:
channel: "stable"
flutter-version: 3.19.0
flutter-version: 3.24.x

# Get flutter dependencies.
- run: flutter pub get
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/coupons/components/coupon_banner.dart
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class CouponBanner extends StatelessWidget {
child: Row(
children: [
IconButton(
onPressed: context.router.pop,
onPressed: context.router.maybePop,
icon: const Icon(
Icons.arrow_back,
color: Colors.white,
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/feedback/components/feedback_banner.dart
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class FeedbackBanner extends StatelessWidget {
child: Row(
children: [
IconButton(
onPressed: context.router.pop,
onPressed: context.router.maybePop,
icon: const Icon(
Icons.arrow_back,
color: Colors.white,
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/feedback/feedback_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class FeedbackScreen extends StatelessWidget {
textColor: Colors.white,
backgroundColor: AppTheme.green,
fontSize: 12.toAutoScaledFont);
context.router.pop();
context.router.maybePop();
}
if (state.error) {
Fluttertoast.showToast(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class HostelChangeBanner extends StatelessWidget {
child: Row(
children: [
IconButton(
onPressed: () => context.router.pop(),
onPressed: () => context.router.maybePop(),
icon: const Icon(
Icons.arrow_back,
color: Colors.white,
Expand Down
4 changes: 2 additions & 2 deletions lib/presentation/login/components/oauth_webview.dart
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class OAuthWebScreen extends StatelessWidget {
onUpdateVisitedHistory: (_, uri, __) {
if (uri != null) {
if (uri.toString().contains('https://channeli.in/feed')) {
context.router.pop();
context.router.maybePop();
//TODO: show dialog box
// SnackBarUtils.showDark('Error', 'Permission Denied!');
}
Expand All @@ -49,7 +49,7 @@ class OAuthWebScreen extends StatelessWidget {
var params = url.split('?').last.split('&');
if (params.first.contains('code')) {
var code = params.first.split('=').last;
context.router.pop(code);
context.router.maybePop(code);
}

return NavigationActionPolicy.CANCEL;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class NotificationBanner extends StatelessWidget {
child: Row(
children: [
IconButton(
onPressed: context.router.pop,
onPressed: context.router.maybePop,
icon: const Icon(
Icons.arrow_back,
color: Colors.white,
Expand Down
4 changes: 2 additions & 2 deletions lib/presentation/profile/profile_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,13 @@ class ProfileScreen extends StatelessWidget {
ProfilePageBloc>()
.add(
const DeleteHostelChangeRequest());
ctx.router.pop();
ctx.router.maybePop();
},
child: const Text('Delete'),
),
TextButton(
onPressed: () =>
ctx.router.pop(),
ctx.router.maybePop(),
child: const Text('Cancel'),
)
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class ResetPasswordBanner extends StatelessWidget {
child: Row(
children: [
IconButton(
onPressed: context.router.pop,
onPressed: context.router.maybePop,
icon: const Icon(
Icons.arrow_back,
color: Colors.white,
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/reset_password/reset_password_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class ResetPasswordScreen extends StatelessWidget {
content: Text('Password reset successfully!'),
backgroundColor: Colors.green,
));
context.router.pop();
context.router.maybePop();
}
},
builder: (context, state) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class CouponDialogBox extends StatelessWidget {
Align(
alignment: Alignment.topRight,
child: GestureDetector(
onTap: context.router.pop,
onTap: context.router.maybePop,
child: const Padding(
padding: EdgeInsets.all(2.0),
child: Icon(Icons.close),
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A new Flutter project.
# pub.dev using `flutter pub publish`. This is preferred for private packages.
publish_to: 'none' # Remove this line if you wish to publish to pub.dev

version: 3.0.3+28
version: 3.0.4+29

environment:
sdk: '>=3.0.0 <4.0.0'
Expand Down

0 comments on commit f603a96

Please sign in to comment.