Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for web version of application #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

onufriievkyrylo
Copy link

No description provided.

Kyrylo Onufriiev added 2 commits January 31, 2018 15:31
@mderazon
Copy link
Owner

@onufriievkyrylo not sure I understand this change, can you explain the use case here ?

@onufriievkyrylo
Copy link
Author

@mderazon I have an app that have web, ios and android versions. I want to send link to some app screen in email and if this link pressed from not supported device like windows phone or desktop it should redirect to the web version of my app. is it clear?

@mderazon
Copy link
Owner

mderazon commented Feb 4, 2018

I think that this is a special case and it's not reasonable to assume that people are going to have the same path across web and ios/android.

I do agree it would be a good design choice to structure your apps / website using the same logical paths but it is rarely the case as most people have legacy websites and have built new android / ios apps on top of them and the paths usually do not match.

@onufriievkyrylo
Copy link
Author

@mderazon so don't you think that would be nice to add a new field for website path? or some flag to use ios/android path for web link. For me the possibility to have a link for web version of application is really so important.

@mderazon
Copy link
Owner

mderazon commented Feb 7, 2018

I would prefer if we had it in non breaking way

@lkelly-dev
Copy link

I agree with @onufriievkyrylo . There should be some way to make the fallback url dynamic.

@mderazon
Copy link
Owner

@lkelly-dev, @onufriievkyrylo using fallback query param does not work for you ?
See here. It overrides the fallback from the options object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants