Meteor package update #769

92hackers · 2015-12-09T03:17:12Z

I'am using this project in my meteor project, and i found the version is still 0.3.0, which is too old,
there is big difference between demo and my developed project.
maybe you have forgotten updating it or something others.
wish that, and i am willing to help : ) !

rosskevin · 2015-12-09T03:19:57Z

Actually I am unfamiliar with meteor all together. @FezVrasta is there something I need to do to make this available via meteor and npm? I'm primarily just making sure good tags exist for bower and updating the release notes.

92hackers · 2015-12-09T14:10:14Z

i have already make the meteor package, code from tag v0.4.5, if i should publish it to the atmospherejs.com ?

FezVrasta · 2015-12-09T14:32:53Z

I think there was a grunt task to update the atmospherejs package... I've not experience with it unfortunately.

rosskevin · 2015-12-09T15:53:12Z

@FezVrasta if you will add rosskevin to the atmospherejs and npmjs sites as a project admin, I'll try to push and see what happens.

FezVrasta · 2015-12-09T16:08:25Z

I lost the password of the account associated with the project :|

edit: actually I can login to my account but I can't find a way to add a collaborator...

rosskevin · 2015-12-09T16:46:02Z

It may give me a good message once it is publishable. @92hackers I need you to try and fix the errors and submit a PR. On master I have updated some of the files, but I'm lost otherwise and I admit I don't have a lot of motivation on this front.

If you can make grunt meteor-test work and submit that as a PR, I should be able to attempt to publish.

92hackers · 2015-12-10T02:14:40Z

got it, i will do it as soon as possible

92hackers · 2015-12-11T09:47:21Z

@rosskevin , can you explain me about meteor/test.js ?
code : var plugins = ["affix", 'alert', "",,,,,,,,];
but , where do you include those plugins ?
and why test those plugins ?

rosskevin · 2015-12-11T14:31:14Z

I have no idea why they were included, but they are BS plugins, so perhaps it was testing that or it was just copies and never fixed. It doesn't seem like a good test of MDB.

rosskevin · 2016-02-03T15:57:27Z

@FezVrasta here is a note on adding contributors/publishing - it recommends creating an organization with people:
http://stackoverflow.com/a/29269583/2363935

I think we either need to get this updated or pull it, people are using a package that is out of date and it makes it look like the project is not working (which it may indeed not be for meteor users).

FezVrasta · 2016-02-03T15:58:30Z

I would drop it at all... If someone wants to maintain it, he will create a fork I guess.

rosskevin · 2016-02-03T16:02:30Z

I don't have access to drop it on atmosphere. I would suggest you drop it (and I'll drop the related grunt code because it doesn't work). If someone steps up and submits a PR, we can go from there.

FezVrasta · 2016-02-03T16:05:43Z

I wonder how should I be able to drop it from atmosphere... The account linked to it is fezvrasta, but I have the credentials to fezvr4sta... when I try to login to fezvrasta it says that such account has not a password set :/

@dandv setup it for me ages ago... If I remember correctly

rosskevin · 2016-02-03T16:08:22Z

If @dandv cannot help pull it, perhaps submit a support request?

FezVrasta · 2016-02-03T16:10:04Z

Let's wait a day to see if he can help us, if not, I'll then submit a ticket.

tsega · 2016-02-03T17:07:57Z

@FezVrasta I must say you have one of the most popular packages on Meteor some 7K+ downloads. I myself use if for almost all of my new projects but I didn't realize it was totally out of sync with the original.

I want to help getting this up to date:

I lost the password of the account associated with the project :|
edit: actually I can login to my account but I can't find a way to add a collaborator...

Here is what you need to do,

Go to meteor.com and sign in with your account, i.e fezvrasta.
Then go to you profile settings to create an organization, https://www.meteor.com/account-settings/organizations ; this way you could add a trusted person like @rosskevin to your organization and he can follow with updating etc.

Note: @rosskevin would also need a meteor.com account.

I would also love to help with this!

rosskevin · 2016-02-03T17:17:04Z

I have a meteor account - it is rosskevin.

@tsega we would love to have your help. What we need right now is a PR that makes the grunt meteor tasks work. It doesn't appear that the grunt meteor-test has any bearing on this library, and may have been copied.

Permissions aside, I just need a PR from a meteor user that ensures I can call grunt meteor when I a have a new version to release.

FezVrasta · 2016-02-03T17:19:14Z

@tsega, sorry but I get this when I try to login to fezvrasta:

If I try to login with my real account fezvr4sta, I can login but I have no access to the repo settings.

tsega · 2016-02-03T17:22:30Z

OK it seems like the user fezvrasta is not a simple user but an organziation.

Your real user is fezvr4sta. Use that to login.

FezVrasta · 2016-02-03T17:30:10Z

Ah! yes!

I've added rosskevin to the collaborators

tsega · 2016-02-03T17:41:41Z

👍 @rosskevin I'll be working on that PR, but I must admin I haven't used grunt, gulp or bower. I'm a total Meteor fanboy 😊

FezVrasta · 2016-02-03T17:42:43Z

I think we just need a task to pubblish the new builds on atmosphere...

tsega · 2016-02-03T19:20:14Z

That's so strange my copy doesn't have that folder, I have your latest commit as well. I'll try to clone again.

rosskevin · 2016-02-03T19:29:27Z

A clean could have run, i.e. if you ran grunt. Just run grunt dist

tsega · 2016-02-03T19:35:46Z

Yes that's correct I did grunt clean earlier. So now I'm getting a very similar error to this one, https://travis-ci.org/FezVrasta/bootstrap-material-design/builds/89655229

rosskevin · 2016-02-03T19:36:46Z

Yes, these are the meteor tests, which appear to be bogus.

tsega · 2016-02-03T20:11:10Z

Could this be something related, themeteorchef/jquery-validation#6

rosskevin · 2016-02-03T20:19:50Z

I have no idea. I'm not sure if I made this clear before, but I think these tests should be deleted because they appear to have been copied from bootstrap.

If you aren't going to make them relevant to MDB, just delete them is my thought.

tsega · 2016-02-03T20:24:51Z

Got the bugger! As I suspected it was a jquery issue. I had to add

$ =jQuery.noConflict();

At the top of the meteor/test.js file on the second line right under user strict;

What's next?

rosskevin · 2016-02-03T20:27:44Z

Try grunt meteor. If you make it up to a publishing error due to credentials, I think that's all you can do, you just need to submit your PR

…strap#769

tsega · 2016-02-03T20:41:07Z

As you expected, everything passed but I was unable to publish due to credentials. Here you go:

tsega · 2016-02-03T20:43:44Z

@rosskevin I've submitted my PR.

Fixed Meteor tests failing because of jQuery conflict. Related #769

rosskevin · 2016-02-03T20:54:10Z

Published, thank you @tsega

tsega · 2016-02-03T21:02:28Z

Thank you @rosskevin for the quick publish! I'm the first one to download it 😄 Please let me know if you need my help with any of the remaining issues.

rosskevin · 2016-02-03T21:06:01Z

The only problem remaining is that there are 4 packages now, 3 of which are no longer relevant:
https://atmospherejs.com/fezvrasta

I cannot seem to delete these others.

tsega · 2016-02-03T21:15:26Z

Ah! That's the only thing I don't like about atmosphere, once published you can't remove a package. They say it has to do with keeping backward compatibility or something. I'm afraid there is nothing we can do about that.

dandv · 2016-02-03T22:30:38Z

Hey guys. Looks like you've sorted out the permissions.

I haven't followed the latest developments, so I'm not sure why the -noglyph package is no longer relevant, but if you want to hide it, run

meteor admin set-unmigrated <package:name>

rosskevin · 2016-02-04T15:39:33Z

@dandv - unfortunately that appears to have failed as well:

$ meteor admin set-unmigrated fezvrasta:bootstrap-material-design-fullpalette
done.                                         [email protected] as unsuccessfully migrated ...                                               
done.                                         [email protected] as unsuccessfully migrated ...                                               
$ meteor admin set-unmigrated fezvrasta:bootstrap-material-design-noglyph
done.                                         [email protected] as unsuccessfully migrated ...                                               
done.                                         [email protected] as unsuccessfully migrated ...                                               
done.                                         [email protected] as unsuccessfully migrated ...                                               
done.                                         [email protected] as unsuccessfully migrated ...                                               
$ meteor admin set-unmigrated fezvrasta:bootstrap-material-design-noicons
done.                                         [email protected] as unsuccessfully migrated ...                                               
done.                                         [email protected] as unsuccessfully migrated ...                                               
done.                                         [email protected] as unsuccessfully migrated ...                                               
done.                                         [email protected] as unsuccessfully migrated ...

tsega · 2016-02-05T08:59:10Z

@rosskevin actually that has worked, if you look at your teams profile on atmosphere the only package now is fezvrasta:bootstrap-material-design. The message as unsuccessfully migrated is what it's supposed to say.

@dandv thanks for the command been looking for something like for a while now. I think it's not being shared with the masses for a reason, right?

rosskevin · 2016-02-05T09:10:47Z

👍

tsega · 2016-02-11T09:23:03Z

Sorry if it's wrong to ask this here but the original problem that lead me here is still bugging me.

On my Android device running 4.1.2, the checkboxes appear but neither the ripple effect or the actual check mark appear when checked. How can I get this to work?

Even more, check boxes that don't have labels cannot be selected. I have the same issues on the iOS emulator but not the android one. Pretty strange, if you ask me!

rosskevin · 2016-02-11T16:16:19Z

@tsega please raise a different issue. We cannot log each and every issue for a meteor issue here.

My initial advice is to log a new issue, and ask for advice. You should know that you are likely to be the one that fixes it, but by logging a separate issue and asking, the community may be able to help you.

On a personal note from someone with deep experience in mobile, please first look at the mobile market share and make sure it is a must-have. While it would be nice to fix this, the mobile market upgrades quickly.

rosskevin · 2016-03-23T16:09:28Z

Meteor guys - see #930, we have officially dropped support and need someone to step up and maintain a package. We will be happy to link to you.

rosskevin added this to the 0.5.5 milestone Dec 9, 2015

rosskevin added a commit that referenced this issue Dec 9, 2015

#769 updated some meteor packages, still not working

93d6bbf

rosskevin changed the title ~~Maybe you have forgotten updating this project in atmospherejs.com( meteor package)~~ Meteor package update Dec 9, 2015

rosskevin added the pr welcome label Dec 9, 2015

rosskevin mentioned this issue Dec 9, 2015

Use nemo64's Bootstrap package for a customizable version of the meteor package #656

Closed

rosskevin removed this from the 0.5.5 milestone Dec 9, 2015

rosskevin mentioned this issue Jan 15, 2016

ripple effect is not working #353

Closed

rosskevin mentioned this issue Feb 3, 2016

ripples effects for some elements does not fire on mobile #424

Closed

tsega added a commit to tsega/bootstrap-material-design that referenced this issue Feb 3, 2016

Fixed Meteor tests failing because of jquery conflict. Related mdboot…

7157527

…strap#769

rosskevin added a commit that referenced this issue Feb 3, 2016

Merge pull request #864 from tsega/master

bb839b8

Fixed Meteor tests failing because of jQuery conflict. Related #769

rosskevin added this to the 0.5.8 milestone Feb 3, 2016

rosskevin closed this as completed Feb 3, 2016

rosskevin removed the needs pr - help wanted label Feb 3, 2016

rosskevin reopened this Feb 4, 2016

rosskevin closed this as completed Feb 5, 2016

mdbootstrap locked and limited conversation to collaborators Feb 11, 2016

Meteor package update #769

Meteor package update #769

Comments

92hackers commented Dec 9, 2015

rosskevin commented Dec 9, 2015

92hackers commented Dec 9, 2015

FezVrasta commented Dec 9, 2015

rosskevin commented Dec 9, 2015

FezVrasta commented Dec 9, 2015

rosskevin commented Dec 9, 2015

92hackers commented Dec 10, 2015

92hackers commented Dec 11, 2015

rosskevin commented Dec 11, 2015

rosskevin commented Feb 3, 2016

FezVrasta commented Feb 3, 2016

rosskevin commented Feb 3, 2016

FezVrasta commented Feb 3, 2016

rosskevin commented Feb 3, 2016

FezVrasta commented Feb 3, 2016

tsega commented Feb 3, 2016

rosskevin commented Feb 3, 2016

FezVrasta commented Feb 3, 2016

tsega commented Feb 3, 2016

FezVrasta commented Feb 3, 2016

tsega commented Feb 3, 2016

FezVrasta commented Feb 3, 2016

tsega commented Feb 3, 2016

rosskevin commented Feb 3, 2016

tsega commented Feb 3, 2016

rosskevin commented Feb 3, 2016

tsega commented Feb 3, 2016

rosskevin commented Feb 3, 2016

tsega commented Feb 3, 2016

rosskevin commented Feb 3, 2016

tsega commented Feb 3, 2016

tsega commented Feb 3, 2016

rosskevin commented Feb 3, 2016

tsega commented Feb 3, 2016

rosskevin commented Feb 3, 2016

tsega commented Feb 3, 2016

dandv commented Feb 3, 2016

rosskevin commented Feb 4, 2016

tsega commented Feb 5, 2016

rosskevin commented Feb 5, 2016

tsega commented Feb 11, 2016

rosskevin commented Feb 11, 2016

rosskevin commented Mar 23, 2016